[RecoveryServices]: add cross region restore support for upcoming reg… #29071
Conversation
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Pull request overview
This pull request aims to add cross-region restore support for two upcoming Azure regions: NortheastUS5 and IndiaSouthCentral. The changes update the region mapping dictionary used for backup and restore operations across regions.
Changes:
- Updated the ChangeLog.md to document the addition of cross-region restore support for the two new regions
- Added region mappings in BackupUtils.cs to map the new regions to their secondary/paired regions
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/RecoveryServices/RecoveryServices/ChangeLog.md | Documents the addition of cross-region restore support for NortheastUS5 and IndiaSouthCentral |
| src/RecoveryServices/RecoveryServices.Backup/Helpers/BackupUtils.cs | Adds region mapping entries for "indiasouthcentral" → "centralindia" and "northeastus5" → "centralus" |
| {"westus", "eastus"}, | ||
| {"eastus2", "centralus"}, | ||
| {"centralus", "eastus2"}, | ||
| {"northeastus5", "centralus"}, |
There was a problem hiding this comment.
This entry for "northeastus5" to "centralus" mapping is a duplicate. The same mapping already exists at line 110 of the file. Dictionary keys must be unique, and having duplicate keys will cause a runtime exception when initializing the dictionary. Please remove this duplicate entry.
| {"northeastus5", "centralus"}, |
There was a problem hiding this comment.
thanks for noticing. I have removed duplicate entry
| --> | ||
|
|
||
| ## Upcoming Release | ||
| * Added Cross region restore support for upcoming regions NortheastUS5 and IndiaSouthCentral |
There was a problem hiding this comment.
The changelog entry mentions adding support for "NortheastUS5", but this region was already added in Version 7.10.0 (see line 31). Since the code change for "northeastus5" at line 79 is a duplicate entry that should be removed, the changelog should only mention "IndiaSouthCentral" as the new region being added in this release.
| * Added Cross region restore support for upcoming regions NortheastUS5 and IndiaSouthCentral | |
| * Added Cross region restore support for upcoming region IndiaSouthCentral. |
| --> | ||
|
|
||
| ## Upcoming Release | ||
| * Added Cross region restore support for upcoming regions NortheastUS5 and IndiaSouthCentral |
There was a problem hiding this comment.
The region name casing is inconsistent with previous changelog entries. Previous entries use lowercase for region names (e.g., "northeastus5" in Version 7.10.0, "eastus3" in Version 7.9.0). For consistency, consider using lowercase: "indiasouthcentral" instead of "IndiaSouthCentral".
| * Added Cross region restore support for upcoming regions NortheastUS5 and IndiaSouthCentral | |
| * Added Cross region restore support for upcoming regions northeastus5 and indiasouthcentral |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
prog-rajkamal
force-pushed
the
buildout/indiasouthcentral
branch
from
9992b96 to
b8fc88c
Compare
…ions NortheastUS5 and IndiaSouthCentral
prog-rajkamal
force-pushed
the
buildout/indiasouthcentral
branch
from
b8fc88c to
71e4ee1
Compare
| --> | ||
|
|
||
| ## Upcoming Release | ||
| * Added Cross region restore support for upcoming regions IndiaSouthCentral |
There was a problem hiding this comment.
The term "upcoming regions" is inconsistent with previous changelog entries which use "new region" (see lines 31 and 35). For consistency with the existing changelog pattern, change "upcoming regions" to "new region".
There was a problem hiding this comment.
We'd better use the same pattern in the change log as per suggested by Copilot.
|
/azp run azure-powershell - security-tools |
|
Azure Pipelines successfully started running 1 pipeline(s). |
3 participants
…ions IndiaSouthCentral
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.