Do not arc enable the nodes for cloud deployed clusters even if they are disconnected from ARC #29074
Conversation
…are in disconnected state
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Pull request overview
This PR modifies the Azure Stack HCI registration flow to prevent automatic Arc enablement of cluster nodes during repair registration when the cluster was deployed through cloud deployment. The change ensures that for cloud-deployed clusters, Arc enablement is handled by the cloud deployment process rather than being triggered manually during repair operations.
Changes:
- Updated MSI flow logic to detect cloud deployments and skip manual Arc enablement in such cases
- Added appropriate logging for the new cloud deployment skip path
- Updated ChangeLog to document the behavior change
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/StackHCI/StackHCI/ChangeLog.md | Documents the new behavior where Arc enablement is skipped for cloud-deployed clusters during repair registration |
| src/StackHCI/StackHCI.Autorest/custom/stackhci.ps1 | Adds cloud deployment detection in Invoke-MSIFlow to conditionally skip Arc enablement, wrapping the existing enablement logic in an else block for non-cloud deployments |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
| --> | ||
| ## Upcoming Release | ||
| * Improved cloud deployment detection during Azure Arc repair operations to prevent duplicate enablement attempts and ensure smoother deployment experiences. | ||
| * If cluster is registered through cloud deployment, arc enablement of nodes will no longer be triggered during repair registration. |
There was a problem hiding this comment.
This change log message is not user friendly. It describes the implementation details instead of a note or update shared with the user.
There was a problem hiding this comment.
Hi @vidai-msft
"Cloud deployment" is infact a customer facing nomenclature : https://learn.microsoft.com/en-us/azure/azure-local/deploy/deployment-introduction?view=azloc-2512
Please help clarify which aspects of this line is not customer friendly
There was a problem hiding this comment.
@bniranjanbhat this message is more like an implementation detail instead of what will bring to the user. I am not saying you should not use the term "cloud deployment". A typical release note should be like improved performance of cloud deployment or fixed bug of cloud deployment or etc. You can refer to the notes in this module or other modules in the ChangeLog.md files.
There was a problem hiding this comment.
@vidai-msft Fixed issue where Arc enablement was incorrectly triggered during repair registration for cloud deployments
Is this fine?
4 participants
Description
In the current registration flow, if the nodes are disconnected from Arc, during repair registration, the nodes will be arc enabled again. But, in case of cloud deployment Arc enablement should not be done even if the machine is disconnected form Arc.
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.