Skip to content

Conversation

@aviranjan24
Copy link
Member

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copilot AI review requested due to automatic review settings January 19, 2026 11:57
@azure-client-tools-bot-prd
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request introduces a new PowerShell module Az.EdgeMarketplace for managing Edge Marketplace resources in Azure. This is the first preview release (version 0.1.0) of an AutoRest-generated module that provides cmdlets for interacting with marketplace publishers, offers, and access tokens.

Changes:

  • Added new Az.EdgeMarketplace module with four cmdlets for managing Edge Marketplace resources
  • Implemented AutoRest-based code generation infrastructure with test scaffolding
  • Included help documentation and examples (currently containing placeholders)

Reviewed changes

Copilot reviewed 41 out of 41 changed files in this pull request and generated 9 comments.

Show a summary per file
File Description
Az.EdgeMarketplace.psd1 Module manifest defining metadata, dependencies, and exported functions
ChangeLog.md Initial changelog entry for version 0.1.0 preview release
help/*.md Help documentation for four cmdlets (contains placeholder examples)
EdgeMarketplace.csproj Project configuration for the wrapper module
EdgeMarketplace.sln Visual Studio solution file including module and dependencies
Properties/AssemblyInfo.cs Assembly metadata for the EdgeMarketplace wrapper
EdgeMarketplace.Autorest/* AutoRest-generated module infrastructure including tests, docs, and utilities
tsp-location.yaml Type specification location configuration (contains placeholder values)
README.md Module documentation explaining AutoRest generation and development
test/*.Tests.ps1 Pester test stubs for all cmdlets (currently skipped)
UX/*.json Azure portal integration metadata for publishers and offers

Comment on lines +66 to +86
### Example 1: {{ Add title here }}
```powershell
{{ Add code here }}
```

```output
{{ Add output here (remove the output block if the example doesn't have an output) }}
```

{{ Add description here }}

### Example 2: {{ Add title here }}
```powershell
{{ Add code here }}
```

```output
{{ Add output here (remove the output block if the example doesn't have an output) }}
```

{{ Add description here }}
Copy link

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The help documentation contains placeholder examples that need to be replaced with actual usage examples. Users require concrete examples showing how to use this cmdlet with real parameter values and expected output.

Copilot generated this review using guidance from repository custom instructions.
Comment on lines +171 to +184
### -RequestId
The name of the publisher.

```yaml
Type: System.String
Parameter Sets: GetExpanded, GetViaIdentityExpanded
Aliases:

Required: True
Position: Named
Default value: None
Accept pipeline input: False
Accept wildcard characters: False
```
Copy link

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parameter description "The name of the publisher." is incorrect for RequestId. This parameter should describe what the request ID represents, not reference a publisher name.

Copilot uses AI. Check for mistakes.
Comment on lines +45 to +65
### Example 1: {{ Add title here }}
```powershell
{{ Add code here }}
```

```output
{{ Add output here (remove the output block if the example doesn't have an output) }}
```

{{ Add description here }}

### Example 2: {{ Add title here }}
```powershell
{{ Add code here }}
```

```output
{{ Add output here (remove the output block if the example doesn't have an output) }}
```

{{ Add description here }}
Copy link

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The help documentation contains placeholder examples that need to be replaced with actual usage examples. Users require concrete examples showing how to use this cmdlet with real parameter values and expected output.

Copilot generated this review using guidance from repository custom instructions.
Comment on lines +2 to +4
commit: <replace with your value>
repo: <replace with your value>
additionalDirectories:
Copy link

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tsp-location.yaml file contains placeholder values that must be replaced with actual repository and commit information before the module can be properly regenerated or maintained. Replace the placeholder text with the actual Azure REST API specs repository URL and the specific commit hash used for generation.

Suggested change
commit: <replace with your value>
repo: <replace with your value>
additionalDirectories:
commit: 4442e8121686218ce2951ab4dc734e489aa5bc08
repo: https://github.com/Azure/azure-rest-api-specs.git
additionalDirectories: []

Copilot uses AI. Check for mistakes.
```

### -EgeMarketPlaceResourceId
The region where the disk will be created.
Copy link

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description for this parameter states "The region where the disk will be created" which is incorrect for a resource ID parameter. The description should explain that this is the Azure Resource Manager identifier for the Edge Marketplace resource.

Copilot uses AI. Check for mistakes.
Comment on lines +10 to +62
## SYNOPSIS
A long-running resource action.

## SYNTAX

### GenerateExpanded (Default)
```
New-AzEdgeMarketplaceOfferAccessToken -OfferId <String> -ResourceUri <String> -EdgeMarketPlaceRegion <String>
[-DeviceSku <String>] [-DeviceVersion <String>] [-EgeMarketPlaceResourceId <String>]
[-HypervGeneration <String>] [-MarketPlaceSku <String>] [-MarketPlaceSkuVersion <String>]
[-PublisherName <String>] [-DefaultProfile <PSObject>] [-AsJob] [-NoWait]
[-WhatIf] [-Confirm] [<CommonParameters>]
```

### GenerateViaJsonString
```
New-AzEdgeMarketplaceOfferAccessToken -OfferId <String> -ResourceUri <String> -JsonString <String>
[-DefaultProfile <PSObject>] [-AsJob] [-NoWait] [-WhatIf] [-Confirm]
[<CommonParameters>]
```

### GenerateViaJsonFilePath
```
New-AzEdgeMarketplaceOfferAccessToken -OfferId <String> -ResourceUri <String> -JsonFilePath <String>
[-DefaultProfile <PSObject>] [-AsJob] [-NoWait] [-WhatIf] [-Confirm]
[<CommonParameters>]
```

### Generate
```
New-AzEdgeMarketplaceOfferAccessToken -OfferId <String> -ResourceUri <String> -Body <IAccessTokenRequest>
[-DefaultProfile <PSObject>] [-AsJob] [-NoWait] [-WhatIf] [-Confirm]
[<CommonParameters>]
```

### GenerateViaIdentityExpanded
```
New-AzEdgeMarketplaceOfferAccessToken -InputObject <IEdgeMarketplaceIdentity> -EdgeMarketPlaceRegion <String>
[-DeviceSku <String>] [-DeviceVersion <String>] [-EgeMarketPlaceResourceId <String>]
[-HypervGeneration <String>] [-MarketPlaceSku <String>] [-MarketPlaceSkuVersion <String>]
[-PublisherName <String>] [-DefaultProfile <PSObject>] [-AsJob] [-NoWait]
[-WhatIf] [-Confirm] [<CommonParameters>]
```

### GenerateViaIdentity
```
New-AzEdgeMarketplaceOfferAccessToken -InputObject <IEdgeMarketplaceIdentity> -Body <IAccessTokenRequest>
[-DefaultProfile <PSObject>] [-AsJob] [-NoWait] [-WhatIf] [-Confirm]
[<CommonParameters>]
```

## DESCRIPTION
A long-running resource action.
Copy link

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The synopsis and description are overly generic. Instead of "A long-running resource action," provide a meaningful description that explains what this cmdlet does, such as "Generates an access token for downloading or accessing marketplace offers" or similar user-focused explanation.

Copilot generated this review using guidance from repository custom instructions.
Comment on lines +56 to +76
### Example 1: {{ Add title here }}
```powershell
{{ Add code here }}
```

```output
{{ Add output here (remove the output block if the example doesn't have an output) }}
```

{{ Add description here }}

### Example 2: {{ Add title here }}
```powershell
{{ Add code here }}
```

```output
{{ Add output here (remove the output block if the example doesn't have an output) }}
```

{{ Add description here }}
Copy link

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The help documentation contains placeholder examples that need to be replaced with actual usage examples. Users require concrete examples showing how to use this cmdlet with real parameter values and expected output.

Copilot generated this review using guidance from repository custom instructions.
Comment on lines +45 to +65
### Example 1: {{ Add title here }}
```powershell
{{ Add code here }}
```

```output
{{ Add output here (remove the output block if the example doesn't have an output) }}
```

{{ Add description here }}

### Example 2: {{ Add title here }}
```powershell
{{ Add code here }}
```

```output
{{ Add output here (remove the output block if the example doesn't have an output) }}
```

{{ Add description here }}
Copy link

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The help documentation contains placeholder examples that need to be replaced with actual usage examples. Users require concrete examples showing how to use this cmdlet with real parameter values and expected output.

Copilot generated this review using guidance from repository custom instructions.
Comment on lines +181 to +194
### -EgeMarketPlaceResourceId
The region where the disk will be created.

```yaml
Type: System.String
Parameter Sets: GenerateExpanded, GenerateViaIdentityExpanded
Aliases:

Required: False
Position: Named
Default value: None
Accept pipeline input: False
Accept wildcard characters: False
```
Copy link

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parameter EgeMarketPlaceResourceId contains a typo. It should be "EdgeMarketPlaceResourceId" (with "dg" not "g"). This inconsistent naming could confuse users.

Copilot uses AI. Check for mistakes.
@isra-fel
Copy link
Member

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants