Skip to content

Conversation

@jayesh-tanna
Copy link
Member

@jayesh-tanna jayesh-tanna commented Dec 9, 2025

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new API spec, a link to the pull request containing these API spec changes should be included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request enables test recording for fine-tuning tests by adding support for HTTP call recording/playback, migrating environment variable access to the test framework's kwargs pattern, and adding sanitizers for sensitive data. The changes allow these tests to be recorded and replayed without requiring live Azure resources.

Key Changes

  • Added RecordedTransport parameters to recording decorators to capture both Azure Core and HTTPX transport calls
  • Migrated from direct os.getenv() calls to kwargs-based parameter access via the servicePreparer fixture
  • Added sanitizers for fine-tuning job IDs, file IDs, checkpoint IDs, and CSV content-type headers in test recordings

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.

File Description
sdk/ai/azure-ai-projects/tests/test_base.py Added new test parameter definitions for fine-tuning job IDs, subscription ID, and resource group to support recorded test playback
sdk/ai/azure-ai-projects/tests/finetuning/test_finetuning_async.py Updated async tests to support recording with RecordedTransport parameters (inconsistently applied), migrated from environment variables to kwargs, corrected print statement prefixes, and updated status assertions for pause/resume operations
sdk/ai/azure-ai-projects/tests/finetuning/test_finetuning.py Updated sync tests with similar recording support (missing RecordedTransport on one test), migrated to kwargs pattern, corrected print statements, and updated status assertions
sdk/ai/azure-ai-projects/tests/conftest.py Added regex sanitizers for fine-tuning job IDs, file IDs, checkpoint IDs, and normalized CSV content-type headers for consistent test recordings across platforms

@jayesh-tanna jayesh-tanna changed the title Ft v11 recording Update fine-tuning test recordings with ID sanitizers Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants