[tsp-client] Update output-dir processing #13355
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the output-dir option processing to improve code clarity by explicitly handling the undefined case. The default value is changed from "." to undefined, and the resolveOutputDir function is updated to check for undefined explicitly before calling resolvePath.
Key Changes:
- Changed the default value of the
output-diroption from"."toundefined - Added explicit conditional logic to handle undefined
output-dirby directly usingprocess.cwd()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix output-dir processing by defaulting the value to undefined unless otherwise specified. There should be no behavioral change due to this update, due to the change to defaulting to undefined, if
--output-dirisn't passed tsp-client will still resolve it to the cwd(), otherwise the value will be resolved in relation to the cwd() same as before.