Implement process_watchdog #517
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Types are now provided by windows.h which is always included first.
Member
Author
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
Just curious why you created a linux and windows watchdog and didn't just create one watchdog file and use the threadpool_timer which is platform agnostic? |
Member
Author
|
Because I didn't want this to be dependent on threadpool. That way, I can use this for threadpool_int. In reply to: 3761788926 |
jebrando
reviewed
Jan 16, 2026
|
|
||
| /*Codes_SRS_PROCESS_WATCHDOG_43_006: [ on_timer_expired shall call LogCriticalAndTerminate to terminate the process. ]*/ | ||
| LogCriticalAndTerminate("Process watchdog timeout after %" PRIu32 " ms", g_timeout_ms); | ||
| } |
Contributor
There was a problem hiding this comment.
Ok, stay with me on this one.
You might want to check the g_watchdog_state to make sure that the stat is WATCHDOG_STATE_INITIALIZED here because of this:
"timer_delete() does not flush pending signals.
It only prevents future expirations."
mattdurak
reviewed
Jan 16, 2026
Member
Author
|
/Azurepipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.