Decommission SAP CAL integration due to SAP API retirement

[nnoaman]

This pull request removes all SAP CAL (Cloud Appliance Library) integration logic from SDAF in response to SAP's announced decommissioning of their public CAL API.

The changes eliminate playbooks, roles, variables, and configuration files related to SAP CAL, as well as all associated validation and provisioning steps. This significantly simplifies the deployment process by removing support for SAP CAL integration.

The most important changes are:

Removal of SAP CAL Playbooks and Roles:

• Deleted the playbook_sapcal_integration.yaml playbook, which handled all SAP CAL integration steps, including resource provisioning and API calls.
• Removed the roles-os/1.5.3-disk-setup-sapcal and roles-sap/6.0.0-sapcal-install roles, including all their tasks, defaults, and variable files. [1] [2] [3] [4]

Variable and Parameter Cleanup:

• Removed SAP CAL-related variables (enable_sap_cal, calapi_kv, sap_cal_product_name) from ansible-input-api.yaml and related validation from playbook_00_validate_parameters.yaml. [1] [2]

Pipeline and Utility Cleanup:

• Deleted the pipeline template collect-calapi-file.yaml, which was used to collect and store the SAP CAL provisioning API response.

Code and Condition Simplification:

• Removed SAP CAL-specific conditions and logic from various roles and tasks, such as in roles-misc/0.2-kv-secrets, roles-sap-os/2.10-sap-notes, and roles-sap-os/2.6-sap-mounts. [1] [2] [3]

[Copilot]

Pull request overview

This pull request removes all SAP CAL (Cloud Appliance Library) integration functionality from SDAF in response to SAP's announced decommissioning of their public CAL API. The changes are comprehensive and clean up all related code, configuration, and pipeline files.

Changes:

• Removed SAP CAL playbooks, roles, and action plugins
• Eliminated SAP CAL-related variables and parameters from Terraform and Ansible configurations
• Deleted SAP CAL-specific pipeline definitions and templates
• Simplified conditional logic in existing roles by removing SAP CAL checks

Reviewed changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
deploy/terraform/terraform-units/modules/sap_system/output_files/variables_global.tf	Removed SAP CAL variable declarations (enable_sap_cal, calapi_kv, sap_cal_product_name)
deploy/terraform/terraform-units/modules/sap_system/output_files/sap-parameters.tmpl	Removed SAP CAL integration section from parameters template
deploy/terraform/terraform-units/modules/sap_system/output_files/inventory.tf	Removed SAP CAL parameters from sap-parameters file generation
deploy/terraform/run/sap_system/tfvar_variables.tf	Deleted SAP CAL integration variable definitions
deploy/terraform/run/sap_system/module.tf	Removed SAP CAL parameters from module outputs
deploy/scripts/pwsh/SDAFUtilities/Public/New-SDAFADOProject.ps1	Removed SAP CAL installation pipeline from ADO project creation
deploy/scripts/pwsh/Output/SDAFUtilities/SDAFUtilities.psm1	Removed SAP CAL installation pipeline from generated module
deploy/scripts/New-SDAFDevopsProject.ps1	Removed SAP CAL installation pipeline creation logic
deploy/pipelines/variables/07-sap-cal-installation-variables.yaml	Deleted entire SAP CAL pipeline variables file
deploy/pipelines/templates/collect-calapi-file.yaml	Deleted template for collecting SAP CAL API response
deploy/pipelines/07-sap-cal-installation.yaml	Deleted entire SAP CAL installation pipeline
deploy/ansible/vars/ansible-input-api.yaml	Removed SAP CAL variables and updated section comments to reflect LVM Configuration
deploy/ansible/roles-sap/6.0.0-sapcal-install/vars/main.yml	Deleted SAP CAL product definitions
deploy/ansible/roles-sap/6.0.0-sapcal-install/tasks/main.yml	Deleted SAP CAL installation tasks
deploy/ansible/roles-sap/6.0.0-sapcal-install/defaults/main.yml	Deleted SAP CAL default variables
deploy/ansible/roles-sap-os/2.6-sap-mounts/tasks/2.6-set_runtime_facts.yaml	Removed SAP CAL conditional check from BOM registration
deploy/ansible/roles-sap-os/2.10-sap-notes/tasks/2.10.3.yaml	Removed SAP CAL conditional check from BOM registration
deploy/ansible/roles-os/1.5.3-disk-setup-sapcal/tasks/main.yml	Deleted entire SAP CAL disk setup role
deploy/ansible/roles-misc/0.2-kv-secrets/tasks/main.yaml	Simplified condition to remove SAP CAL operation check
deploy/ansible/playbook_sapcal_integration.yaml	Deleted entire SAP CAL integration playbook
deploy/ansible/playbook_00_validate_parameters.yaml	Removed SAP CAL parameter validation
deploy/ansible/action_plugins/public_api.py	Deleted entire SAP CAL API integration plugin

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.