No recreate for azapi_resource_action resource on type change

[bloewes]

The azapi_resource_action resource will force re-creation if the type field changes. This means that simply updating the api-version (for example, from 2022-05-01 to 2023-01-01) can cause the resource to be destroyed and recreated, which is problematic—especially if when = "destroy" is set. The resource should still be sufficiently re-created if any of the other marked arguments change.

[matt-FFFFFF]

As an alternative here you can use terraform's removed block then you can add your new configuration...

Changing the action type would usually mean the action should be re-created, your change would mean that a caller could change the action to a totally different API call. Even with only an API version change there could be a different effect.

Instead...

# remove old resource from state and forget it (no destroy)
removed {
  from = azapi_resource_action.foo
  lifecycle {
    destroy = false
  }
}

# add new resource
resource "azapi_resource_action" "bar" {
  # new config
}

[bloewes]

For the case when="destroy": since the action hasn’t happened yet, this change makes sense and shouldn’t have any side effects. Is it possible to make the re-creation of the resource’s type conditional on the value of when?

Otherwise, with many resources and resource instances that we use and frequent API changes, this approach doesn’t seem effective for my our case. I prefer to continue using ignore_changes = [type] in that case.

[matt-FFFFFF]

shouldn’t have any side effects

The change you are proposing will most definately have side effects as it stands.

Considering only the when = "destroy" use case... Perhaps it is possible to automate the forget operation. E.g. don't run the resource's .Delete() method.

[ms-henglu]

I think it makes sense that the plan modifier allows api-version upgrade without replacing the resource. I'll open another PR to support it and it could be included in the next release.

[ms-henglu]

Hi @bloewes , I just realized that even the action resource is not recreated, it'll still trigger one http request if when != destroy, is it okay for your case?

[bloewes]

@ms-henglu For my case, I only care about when = destory, because those would make a DELETE api call which is then not recoverable. But if the case when = destory does not trigger any call, I'm fine.

[ms-henglu]

I'll close this PR in favor of #1035, hope you don't mind. Let me know if you have any questions. Thanks for the PR again!