Skip CRDs with AKS addon manager label #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhmadhav
requested review from
anagg929,
atchutbarli,
bavneetsingh16 and
bgriddaluru
as code owners
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
atchutbarli
reviewed
Jan 13, 2026
| labels = crd_json.get("metadata", {}).get("labels", {}) | ||
| if labels.get("addonmanager.kubernetes.io/mode") == "Reconcile": | ||
| # Skip deletion for CRDs managed by AKS addon manager | ||
| continue |
There was a problem hiding this comment.
do we want to completely skip the delete? i assumed its selective skip for those with the label
atchutbarli
reviewed
Jan 13, 2026
| for crds in consts.CRD_FOR_FORCE_DELETE: | ||
| full_crds = f"{crds}.{cloud_based_domain}" | ||
|
|
||
| # Check if CRD has the addonmanager.kubernetes.io/mode: Reconcile label |
There was a problem hiding this comment.
once tested , can you please add snapshots of the state of CRDs to the pr description as well for reference.
atchutbarli
requested changes
Jan 13, 2026
atchutbarli
left a comment
atchutbarli
left a comment
There was a problem hiding this comment.
can you please add the test results as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az connectedk8s
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.