Draft
Conversation
Contributor
|
Great start! I agree that having pre-computed values will be better. This will let someone see the complete waveform immediately (and not have to wait several seconds for the whole track to be downloaded). I tested this out locally, and there's something about this new player code that will pretty reliably crash my browser tab (using a chromebook), especially when playing very long tracks. I think the browser runs out of memory. When I try on a machine with more memory, playing S01E14 - Jam 1 results in about 3.5GB of memory being used. |
Contributor
Author
|
Hmm, I was developing in Chrome. I have a feeling this is the hack that I was using to get the data probably doesn't help. Will look at this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extremely rough.
In need of tidying up.
Ideally, the values would be precomputed as the Web Audio API seems to need an update to provide a buffer from the
<audio>element.Want to add playhead position via the visualisation too. Will add this soon.
Also, will add more player UI but want to get something in for now.