Open
Conversation
Helps to define when a die has been dropped, rerolled, or exploded
and prevent collision
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding an additional
operationproperty descriptor toRollBasedie objects. This will easily flag dice as 'drop', 'reroll' and 'explode'.Use Case: After getting the final roll results, I'd like to mark which dice have been dropped, rerolled, or exploded. For example, when rolling
4d6dl1. Using thevalidproperty doesn't always explain why a die may have been invalidated. Also, a dice that iscritical: "successdoesn't always explode. This new property will help to clear that up for post-processing.