Skip to content

**hotfix/support-customize-validthru-and-product-mapper-injection** #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
phandinhthe merged 3 commits into from
Jan 15, 2026
Merged

**hotfix/support-customize-validthru-and-product-mapper-injection** #575

phandinhthe merged 3 commits into from
Jan 15, 2026

Conversation

@phandinhthe
Copy link

@phandinhthe phandinhthe commented Jan 14, 2026 •
edited
Loading

Description

  • feat: Inject ProductMapper in ProductIngestionSaga and BatchProductIngestionSaga.
  • feat: Add custom mapper for validThru in ProductMapper.
  • test: Update tests to support ProductMapper injection.

Checklist

  • I made sure, I read CONTRIBUTING.md to put right branch prefix as per my need.
  • I made sure to update CHANGELOG.md.
  • I made sure to update Stream Wiki(only valid in case of new stream module or architecture changes).
  • My changes are adequately tested.
  • I made sure all the SonarCloud Quality Gate are passed.

@phandinhthe
**hotfix/support-customize-validthru-and-product-mapper-injection**
7265606 
- feat: Inject `ProductMapper` in `ProductIngestionSaga` and `BatchProductIngestionSaga`.
- feat: Add custom mapper for `validThru` in `ProductMapper`.
- test: Update tests to support `ProductMapper` injection.
@phandinhthe phandinhthe requested a review from a team as a code owner January 14, 2026 06:00
@phandinhthe
**hotfix/support-customize-validthru-and-product-mapper-injection**
8f70af0 
feat(product-mapper): add `validThru` mapping with custom parser.
- Implement `mapValidThru` method to handle date parsing for `validThru`.
- Update `ProductMapper` to include `validThru` mappings.
- Extend unit tests to cover `validThru` logic.
@phandinhthe
fix(hotfix/support-customize-validthru-and-product-mapper-injection):…
76c5240 
… enhance ValidThru mappings and add ProductMapper mocks

- Simplify `mapValidThru` logic in `ProductMapper`
- Add `ProductMapper` mocks in `BatchProductIngestionSagaTest` and `ProductIngestionSagaTest`
- Add test for `validThru` null case in `ProductMapperTest`
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 14, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
83.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@phandinhthe phandinhthe merged commit 3525dc8 into support/7.1.x Jan 15, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shafiquech shafiquech shafiquech approved these changes

@sushiljoshi22 sushiljoshi22 sushiljoshi22 approved these changes

@sunithabackbase sunithabackbase sunithabackbase approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@phandinhthe @shafiquech @sushiljoshi22 @sunithabackbase