Skip to content

chore: grantRole to admin, and renounceRole to deployer #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0xKoaj merged 5 commits into from
Jan 7, 2025
Merged

chore: grantRole to admin, and renounceRole to deployer #87

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7dfea8b
chore: grantRole to admin, and renounceRole to deployer
0xKoaj Jan 7, 2025
9badfb8
chore: fix lint
0xKoaj Jan 7, 2025
c6e3309
chore: fix import
0xKoaj Jan 7, 2025
432ff61
chore: grant and revoke admin
0xKoaj Jan 7, 2025
8622863
chore: fix lint
0xKoaj Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions script/DeployCore.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,16 @@
FirewallAccess firewallAccess = FirewallAccess(getDeployedAddress("V1_FACCESS"));
ExternalFirewall externalFirewall = ExternalFirewall(getDeployedAddress("V1_FEXTERNAL"));
address vault = getDeployedAddress("V1_VAULT");
bytes32 DEFAULT_ADMIN_ROLE = firewallAccess.DEFAULT_ADMIN_ROLE();

Check warning on line 35 in script/DeployCore.sol

View workflow job for this annotation

GitHub Actions / lint 

Variable name must be in mixedCase

/// will renounce later below
firewallAccess.grantRole(FIREWALL_ADMIN_ROLE, msg.sender);
firewallAccess.grantRole(PROTOCOL_ADMIN_ROLE, msg.sender);

firewallAccess.grantRole(DEFAULT_ADMIN_ROLE, admin);
firewallAccess.grantRole(PROTOCOL_ADMIN_ROLE, admin);
firewallAccess.grantRole(FIREWALL_ADMIN_ROLE, admin);

/// let protected contract execute checkpoints on the external firewall
firewallAccess.grantRole(CHECKPOINT_EXECUTOR_ROLE, vault);
firewallAccess.grantRole(CHECKPOINT_EXECUTOR_ROLE, firewallRouter);
Expand All @@ -51,5 +56,6 @@

firewallAccess.renounceRole(FIREWALL_ADMIN_ROLE, msg.sender);
firewallAccess.renounceRole(PROTOCOL_ADMIN_ROLE, msg.sender);
firewallAccess.renounceRole(DEFAULT_ADMIN_ROLE, msg.sender);
}
}
Loading