fix(clock): Clocks are now self-correcting and use safeSetInterval#7
Open
y9san9 wants to merge 1 commit intoBaseSecrete:masterfrom
Open
fix(clock): Clocks are now self-correcting and use safeSetInterval#7y9san9 wants to merge 1 commit intoBaseSecrete:masterfrom
y9san9 wants to merge 1 commit intoBaseSecrete:masterfrom
Conversation
Member
|
Thanks. I'm not sure to understand the drifting issue, because it's not very important if the clock is updated too early or too late. Can you explain the issue you're having when the drift is too large? I will force me to keep a tab open to check after few days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I love your app. Use it all the time with my friends. But js clocks are frustrating. I've seen some discussions about mega-optimizations and fetching the correct time... But here is my simple thing that fixes most of the problems: self-correcting timeout that dodges drift.