optimize compression settings for 7z and ZIP formats

[jwaisner]

User description

Improves build time by approximately 10%

---

PR Type

Enhancement

---

Description

• Optimizes 7z compression with LZMA2 algorithm and increased dictionary size

• Enhances ZIP compression with Deflate algorithm and multi-threading support

• Adds diagnostic echo messages for compression format tracking

• Reorders ZIP compression arguments for consistency and clarity

---

Diagram Walkthrough

flowchart LR
  A["Compression Settings"] --> B["7z Format"]
  A --> C["ZIP Format"]
  B --> D["LZMA2 + 256MB Dictionary"]
  B --> E["Multi-threading + Solid Archive"]
  C --> F["Deflate + 15 Pass Compression"]
  C --> G["Multi-threading Support"]

Loading

File Walkthrough

Relevant files

Enhancement

build-commons.xml Enhanced compression algorithms and multi-threading configuration build/build-commons.xml Modified 7z compression: changed -mmt6 to -mmt and added -md=256m, -ms=on, -mfb=273 for enhanced compression ratio Enhanced ZIP compression: added -tzip, -mx9, -mmt arguments and reordered parameters for consistency Added diagnostic echo messages for both 7z and ZIP compression formats Improved argument ordering in ZIP compression command for better readability +11/-3

---

[qodo-code-review]

PR Compliance Guide 🔍

(Compliance updated until commit 3ab2a8e)

Below is a summary of compliance checks for this PR:

Security Compliance
🟢	No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
⚪	🎫 No ticket provided Create ticket/issue
Codebase Duplication Compliance
⚪	Codebase context is not defined Follow the guide to enable codebase context checks.
Custom Compliance
🟢	Generic: Meaningful Naming and Self-Documenting Code Objective: Ensure all identifiers clearly express their purpose and intent, making code self-documenting Status: Passed
	Generic: Secure Error Handling Objective: To prevent the leakage of sensitive system information through error messages while providing sufficient detail for internal debugging. Status: Passed
	Generic: Secure Logging Practices Objective: To ensure logs are useful for debugging and auditing without exposing sensitive information like PII, PHI, or cardholder data. Status: Passed
⚪	Generic: Comprehensive Audit Trails Objective: To create a detailed and reliable record of critical system actions for security analysis and compliance. Status: Limited auditing: New echo messages provide minimal activity traces but lack user ID, timestamps, and outcome context required for comprehensive audit trails. Referred Code <echo message="Compressing with 7z format (optimized settings)..."/> <exec executable="${7za}" failonerror="true"> <arg value="a"/> <arg value="-t7z"/> <arg value="@{dest}"/> <arg value="@{src}"/> <arg value="-m0=LZMA2"/> <arg value="-mx9"/> <arg value="-mmt"/> <arg value="-md=256m"/> <arg value="-ms=on"/> <arg value="-mfb=273"/> </exec> </then> <elseif> <equals arg1="@{format}" arg2="zip"/> <then> <echo message="Compressing with ZIP format (optimized settings)..."/> <exec executable="${7za}" failonerror="true"> <arg value="a"/> <arg value="-tzip"/> ... (clipped 8 lines)
	Generic: Robust Error Handling and Edge Case Management Objective: Ensure comprehensive error handling that provides meaningful context and graceful degradation Status: Missing error context: While failonerror is enabled, added steps do not capture or log actionable error details or handle edge cases like missing binaries or invalid paths. Referred Code <exec executable="${7za}" failonerror="true"> <arg value="a"/> <arg value="-t7z"/> <arg value="@{dest}"/> <arg value="@{src}"/> <arg value="-m0=LZMA2"/> <arg value="-mx9"/> <arg value="-mmt"/> <arg value="-md=256m"/> <arg value="-ms=on"/> <arg value="-mfb=273"/> </exec> </then> <elseif> <equals arg1="@{format}" arg2="zip"/> <then> <echo message="Compressing with ZIP format (optimized settings)..."/> <exec executable="${7za}" failonerror="true"> <arg value="a"/> <arg value="-tzip"/> <arg value="@{dest}"/> ... (clipped 8 lines)
	Generic: Security-First Input Validation and Data Handling Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent vulnerabilities Status: Unvalidated inputs: The macro accepts external attributes like @{src}, @{dest}, and @{format} without visible validation or sanitization before passing to exec. Referred Code <macrodef name="sevenzip"> <attribute name="src"/> <attribute name="dest"/> <attribute name="format" default="7z"/> <sequential> <if> <equals arg1="@{format}" arg2="7z"/> <then> <echo message="Compressing with 7z format (optimized settings)..."/> <exec executable="${7za}" failonerror="true"> <arg value="a"/> <arg value="-t7z"/> <arg value="@{dest}"/> <arg value="@{src}"/> <arg value="-m0=LZMA2"/> <arg value="-mx9"/> <arg value="-mmt"/> <arg value="-md=256m"/> <arg value="-ms=on"/> <arg value="-mfb=273"/> </exec> ... (clipped 16 lines)

Compliance status legend

🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

---

Previous compliance checks

Compliance check up to commit 3ab2a8e

Security Compliance
⚪	Resource exhaustion risk Description: Setting 7z dictionary size to 256MB (-md=256m) and enabling maximum compression with multi-threading can significantly increase memory/CPU usage, potentially causing build agent resource exhaustion or denial of service on low-memory runners. build-commons.xml [60-71] Referred Code <echo message="Compressing with 7z format (optimized settings)..."/> <exec executable="${7za}" failonerror="true"> <arg value="a"/> <arg value="-t7z"/> <arg value="@{dest}"/> <arg value="@{src}"/> <arg value="-m0=LZMA2"/> <arg value="-mx9"/> <arg value="-mmt"/> <arg value="-md=256m"/> <arg value="-ms=on"/> <arg value="-mfb=273"/>
	Resource exhaustion risk Description: Enabling multi-threading (-mmt) and high compression parameters for ZIP may overload constrained CI runners, leading to potential build instability or denial of service due to resource contention. build-commons.xml [77-88] Referred Code <echo message="Compressing with ZIP format (optimized settings)..."/> <exec executable="${7za}" failonerror="true"> <arg value="a"/> <arg value="-tzip"/> <arg value="@{dest}"/> <arg value="@{src}"/> <arg value="-mm=Deflate"/> <arg value="-mx9"/> <arg value="-mfb=258"/> <arg value="-mpass=15"/> <arg value="-mmt"/> <arg value="-r"/>
Ticket Compliance
⚪	🎫 No ticket provided Create ticket/issue
Codebase Duplication Compliance
⚪	Codebase context is not defined Follow the guide to enable codebase context checks.
Custom Compliance
🟢	Generic: Meaningful Naming and Self-Documenting Code Objective: Ensure all identifiers clearly express their purpose and intent, making code self-documenting Status: Passed
	Generic: Secure Error Handling Objective: To prevent the leakage of sensitive system information through error messages while providing sufficient detail for internal debugging. Status: Passed
	Generic: Secure Logging Practices Objective: To ensure logs are useful for debugging and auditing without exposing sensitive information like PII, PHI, or cardholder data. Status: Passed
⚪	Generic: Comprehensive Audit Trails Objective: To create a detailed and reliable record of critical system actions for security analysis and compliance. Status: Lacks audit logs: The new compression actions add echo messages but do not log user/context or outcomes, which may be required for critical build operations. Referred Code <echo message="Compressing with 7z format (optimized settings)..."/> <exec executable="${7za}" failonerror="true"> <arg value="a"/> <arg value="-t7z"/> <arg value="@{dest}"/> <arg value="@{src}"/> <arg value="-m0=LZMA2"/> <arg value="-mx9"/> <arg value="-mmt"/> <arg value="-md=256m"/> <arg value="-ms=on"/> <arg value="-mfb=273"/> </exec> </then> <elseif> <equals arg1="@{format}" arg2="zip"/> <then> <echo message="Compressing with ZIP format (optimized settings)..."/> <exec executable="${7za}" failonerror="true"> <arg value="a"/> <arg value="-tzip"/> ... (clipped 9 lines)
	Generic: Robust Error Handling and Edge Case Management Objective: Ensure comprehensive error handling that provides meaningful context and graceful degradation Status: Sparse error context: While exec uses failonerror="true", the added echo messages do not capture or log failure reasons or edge cases such as missing binaries or invalid paths. Referred Code <echo message="Compressing with 7z format (optimized settings)..."/> <exec executable="${7za}" failonerror="true"> <arg value="a"/> <arg value="-t7z"/> <arg value="@{dest}"/> <arg value="@{src}"/> <arg value="-m0=LZMA2"/> <arg value="-mx9"/> <arg value="-mmt"/> <arg value="-md=256m"/> <arg value="-ms=on"/> <arg value="-mfb=273"/> </exec> </then> <elseif> <equals arg1="@{format}" arg2="zip"/> <then> <echo message="Compressing with ZIP format (optimized settings)..."/> <exec executable="${7za}" failonerror="true"> <arg value="a"/> <arg value="-tzip"/> ... (clipped 9 lines)
	Generic: Security-First Input Validation and Data Handling Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent vulnerabilities Status: Unvalidated inputs: The macro attributes @{src}, @{dest}, and @{format} are passed to exec without visible validation or sanitization against dangerous values. Referred Code <macrodef name="sevenzip"> <attribute name="src"/> <attribute name="dest"/> <attribute name="format" default="7z"/> <sequential> <if> <equals arg1="@{format}" arg2="7z"/> <then> <echo message="Compressing with 7z format (optimized settings)..."/> <exec executable="${7za}" failonerror="true"> <arg value="a"/> <arg value="-t7z"/> <arg value="@{dest}"/> <arg value="@{src}"/> <arg value="-m0=LZMA2"/> <arg value="-mx9"/> <arg value="-mmt"/> <arg value="-md=256m"/> <arg value="-ms=on"/> <arg value="-mfb=273"/> </exec> ... (clipped 17 lines)

[qodo-code-review]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Possible issue	Reduce memory usage during compression To prevent potential out-of-memory errors on build systems, reduce the LZMA2 dictionary size for 7z compression from 256m to a more conservative 64m, which lowers the required RAM. build/build-commons.xml [66-71] <arg value="-m0=LZMA2"/> <arg value="-mx9"/> <arg value="-mmt"/> -<arg value="-md=256m"/> +<arg value="-md=64m"/> <arg value="-ms=on"/> <arg value="-mfb=273"/> Apply / Chat Suggestion importance[1-10]: 8 __ Why: The suggestion correctly identifies that the -md=256m setting requires a large amount of RAM, which could cause build failures on resource-constrained systems, and proposes a more robust alternative.	Medium
More