You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The configuration uses placeholder paths (BEARSAMPP_WIN_PATH) that need to be properly replaced at runtime. Verify the path substitution mechanism works correctly.
ECHO prefix = %BEARSAMPP_NODEJS_PATH%>%BEARSAMPP_NODEJS_CONFIG_PATH%
-+IF NOT EXIST "%BEARSAMPP_NODEJS_CONFIG_PATH%" (+ ECHO Error: Failed to create npm config file+ EXIT /B 1+)
"%BEARSAMPP_NODEJS_PATH%\nodevars.bat" & "%BEARSAMPP_NODEJS_PATH%\npm" config set globalconfig "%BEARSAMPP_NODEJS_CONFIG_PATH%" --global
Apply this suggestion
Suggestion importance[1-10]: 8
Why: Adding error handling for config file creation is crucial for robustness, as failure to create the config file would cause subsequent npm operations to fail. The suggestion provides proper error detection and graceful exit.
8
Validate required executables before usage
Validate that the required Node.js executables exist before attempting to use them
+IF NOT EXIST "%BEARSAMPP_NODEJS_PATH%\nodevars.bat" (+ ECHO Error: nodevars.bat not found+ EXIT /B 1+)+IF NOT EXIST "%BEARSAMPP_NODEJS_PATH%\npm" (+ ECHO Error: npm not found+ EXIT /B 1+)
"%BEARSAMPP_NODEJS_PATH%\nodevars.bat" & "%BEARSAMPP_NODEJS_PATH%\npm" config set globalconfig "%BEARSAMPP_NODEJS_CONFIG_PATH%" --global
Apply this suggestion
Suggestion importance[1-10]: 8
Why: Checking for the existence of critical executables before attempting to use them prevents cryptic errors and provides clear error messages. This is essential for proper script execution and troubleshooting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Enhancement
Description
Added Node.js version 23.6.1 configuration and launch scripts.
Introduced new configuration files for npm and Node.js.
Updated
build.propertiesto reflect new bundle release version.Included
.npmignoreand other related files for Node.js setup.Changes walkthrough 📝
launch.bat
Add launch script for Node.js setupbin/nodejs23.6.1/launch.bat
nodevars.bat.bearsampp.conf
Add Node.js configuration filebin/nodejs23.6.1/bearsampp.conf
.npmignore
Add empty .npmignore filebin/nodejs23.6.1/etc/.npmignore
.npmignorefile for npm configuration.npmrc
Add npm configuration filebin/nodejs23.6.1/etc/npmrc
npmrc.ber
Add backup npm configuration filebin/nodejs23.6.1/etc/npmrc.ber
npmrc
Add npmrc file for Node.js prefixbin/nodejs23.6.1/node_modules/npm/npmrc
npmrc.ber
Add backup npmrc file for Node.js prefixbin/nodejs23.6.1/node_modules/npm/npmrc.ber
build.properties
Update bundle release version in build.propertiesbuild.properties
bundle.releaseto reflect new release version.