Skip to content

NodeJS 23.11.0#22

Merged
N6REJ merged 1 commit intomainfrom
23.11.0
Apr 23, 2025
Merged

NodeJS 23.11.0#22
N6REJ merged 1 commit intomainfrom
23.11.0

Conversation

@jwaisner
Copy link
Contributor

@jwaisner jwaisner commented Apr 19, 2025

PR Type

enhancement


Description

  • Add Node.js 23.11.0 support with configuration files

  • Introduce launch script for Node.js 23.11.0 environment setup

  • Update release and build properties for new version

  • Register new version in releases list


Changes walkthrough 📝

Relevant files
Enhancement
5 files
launch.bat
Add launch script for Node.js 23.11.0 environment               
+12/-0   
bearsampp.conf
Add Node.js 23.11.0 configuration file                                     
+8/-0     
.npmignore
Add .npmignore for Node.js 23.11.0 package                             
+1/-0     
npmrc
Add npmrc configuration for Node.js 23.11.0                           
+5/-0     
npmrc.ber
Add npmrc.ber configuration for Node.js 23.11.0                   
+5/-0     
Configuration changes
2 files
build.properties
Update bundle release version for new Node.js                       
+1/-1     
releases.properties
Register Node.js 23.11.0 in releases list                               
+1/-0     

Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • @qodo-code-review
    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Incorrect URL

    The download URL for Node.js 23.11.0 contains an incorrect date (2025.3.2) in the filename instead of the current release date (2025.4.19).

    23.11.0 = https://github.com/Bearsampp/module-nodejs/releases/download/2025.4.19/bearsampp-nodejs-23.11.0-2025.3.2.7z

    @qodo-code-review
    Copy link
    Contributor

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    Possible issue
    Fix incorrect URL date

    The URL contains an incorrect date in the filename. The date in the URL should
    match the release date (2025.4.19) instead of 2025.3.2.

    releases.properties [27]

    -23.11.0 = https://github.com/Bearsampp/module-nodejs/releases/download/2025.4.19/bearsampp-nodejs-23.11.0-2025.3.2.7z
    +23.11.0 = https://github.com/Bearsampp/module-nodejs/releases/download/2025.4.19/bearsampp-nodejs-23.11.0-2025.4.19.7z
    • Apply this suggestion
    Suggestion importance[1-10]: 9

    __

    Why: The suggestion correctly identifies a version mismatch in the URL. The filename contains "2025.3.2" while the release date in the URL path is "2025.4.19". This inconsistency would likely cause download failures.

    High
    Handle paths with spaces

    Add quotes around the path variables to handle paths with spaces correctly.
    Without quotes, paths containing spaces will cause the command to fail.

    bin/nodejs23.11.0/launch.bat [8]

    -ECHO prefix = %BEARSAMPP_NODEJS_PATH%>%BEARSAMPP_NODEJS_CONFIG_PATH%
    +ECHO prefix = "%BEARSAMPP_NODEJS_PATH%">"%BEARSAMPP_NODEJS_CONFIG_PATH%"
    • Apply this suggestion
    Suggestion importance[1-10]: 8

    __

    Why: Adding quotes around path variables is a critical fix for batch files as it prevents command failures when paths contain spaces. This is a common source of bugs in Windows batch scripts.

    Medium
    • More

    @N6REJ N6REJ merged commit 91d40fc into main Apr 23, 2025
    @N6REJ N6REJ deleted the 23.11.0 branch April 23, 2025 13:38
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    2 participants