Skip to content

Add Node.js version 24.4.1 with configuration and launch scripts#24

Merged
jwaisner merged 1 commit intomainfrom
24.4.1
Aug 1, 2025
Merged

Add Node.js version 24.4.1 with configuration and launch scripts#24
jwaisner merged 1 commit intomainfrom
24.4.1

Conversation

@N6REJ
Copy link
Collaborator

@N6REJ N6REJ commented Jul 31, 2025

PR Type

Enhancement


Description

  • Add Node.js version 24.4.1 with complete configuration

  • Include launch scripts and npm configuration files

  • Update bundle release version to 2025.7.31

  • Add new release entry for version 24.4.1


Diagram Walkthrough

flowchart LR
  A["Node.js 24.4.1"] --> B["Configuration Files"]
  A --> C["Launch Scripts"]
  A --> D["NPM Setup"]
  B --> E["bearsampp.conf"]
  C --> F["launch.bat"]
  D --> G["npmrc files"]
  H["Build Properties"] --> I["Release 2025.7.31"]
  J["Releases Properties"] --> K["24.4.1 Entry"]
Loading

File Walkthrough

Relevant files
Configuration changes
launch.bat
Add Node.js launch batch script                                                   

bin/nodejs24.4.1/launch.bat

  • Create Windows batch script for Node.js initialization
  • Set environment variables for Node.js and npm paths
  • Configure npm global settings and launch Node.js environment
+12/-0   
bearsampp.conf
Add Bearsampp configuration for Node.js 24.4.1                     

bin/nodejs24.4.1/bearsampp.conf

  • Define Node.js 24.4.1 version configuration
  • Specify executable names and paths for Node.js components
  • Set bundle release version placeholder
+8/-0     
npmrc
Add npm configuration file                                                             

bin/nodejs24.4.1/etc/npmrc

  • Configure npm cache directory path
  • Set global and user configuration file locations
  • Define npm initialization module path
+4/-0     
npmrc.ber
Add npm backup configuration file                                               

bin/nodejs24.4.1/etc/npmrc.ber

  • Duplicate npm configuration with .ber extension
  • Same cache and configuration paths as npmrc
  • Backup or template configuration file
+4/-0     
npmrc
Add npm prefix configuration                                                         

bin/nodejs24.4.1/node_modules/npm/npmrc

  • Set npm prefix path to Node.js 24.3.0 directory
  • Configure npm installation prefix location
+1/-0     
npmrc.ber
Add npm prefix backup configuration                                           

bin/nodejs24.4.1/node_modules/npm/npmrc.ber

  • Backup version of npm prefix configuration
  • Same prefix path as main npmrc file
+1/-0     
build.properties
Update bundle release version                                                       

build.properties

  • Update bundle release version from 2025.7.2 to 2025.7.31
  • Maintain bundle name, type, and format settings
+1/-1     
releases.properties
Add Node.js 24.4.1 release entry                                                 

releases.properties

  • Add new entry for Node.js version 24.4.1
  • Include download URL for 2025.7.31 release
+1/-0     

@N6REJ N6REJ added bug 🐛 For known bugs Enhancement labels Jul 31, 2025
@qodo-code-review
Copy link
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Version Mismatch

The npm prefix path references nodejs24.3.0 instead of the current version 24.4.1, which could cause incorrect module installation paths and runtime issues.

prefix = ~BEARSAMPP_WIN_PATH~\bin\nodejs\nodejs24.3.0\
Version Mismatch

Same issue as npmrc file - the backup configuration also references the wrong Node.js version (24.3.0 instead of 24.4.1).

prefix = ~BEARSAMPP_WIN_PATH~\bin\nodejs\nodejs24.3.0\
Missing Validation

The batch script lacks error handling and validation for critical operations like file existence checks and command execution results, which could lead to silent failures.

ECHO prefix = %BEARSAMPP_NODEJS_PATH%>%BEARSAMPP_NODEJS_CONFIG_PATH%

"%BEARSAMPP_NODEJS_PATH%\nodevars.bat" & "%BEARSAMPP_NODEJS_PATH%\npm" config set globalconfig "%BEARSAMPP_NODEJS_CONFIG_PATH%" --global

@qodo-code-review
Copy link
Contributor

qodo-code-review bot commented Jul 31, 2025

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
Possible issue
Fix incorrect version path reference

The npm prefix path references version 24.3.0 instead of 24.4.1. This will cause
npm to install packages in the wrong directory and break the Node.js 24.4.1
installation.

bin/nodejs24.4.1/node_modules/npm/npmrc [1]

-prefix = ~BEARSAMPP_WIN_PATH~\bin\nodejs\nodejs24.3.0\
+prefix = ~BEARSAMPP_WIN_PATH~\bin\nodejs\nodejs24.4.1\

[Suggestion processed]

Suggestion importance[1-10]: 10

__

Why: The suggestion correctly identifies a critical bug where the prefix path points to the wrong Node.js version, which would break the installation.

High
Fix version mismatch in backup

The backup npm configuration file also references the wrong version 24.3.0
instead of 24.4.1. This inconsistency could cause issues when the backup
configuration is used.

bin/nodejs24.4.1/node_modules/npm/npmrc.ber [1]

-prefix = ~BEARSAMPP_WIN_PATH~\bin\nodejs\nodejs24.3.0\
+prefix = ~BEARSAMPP_WIN_PATH~\bin\nodejs\nodejs24.4.1\

[Suggestion processed]

Suggestion importance[1-10]: 10

__

Why: The suggestion correctly identifies a critical bug in a backup configuration file where the prefix path points to the wrong Node.js version, which would cause issues if used.

High
General
Use conditional command chaining operator

Using & to chain commands can cause the second command to execute regardless of
the first command's success. Use && to ensure the npm config command only runs
if nodevars.bat succeeds.

bin/nodejs24.4.1/launch.bat [10]

-"%BEARSAMPP_NODEJS_PATH%\nodevars.bat" & "%BEARSAMPP_NODEJS_PATH%\npm" config set globalconfig "%BEARSAMPP_NODEJS_CONFIG_PATH%" --global
+"%BEARSAMPP_NODEJS_PATH%\nodevars.bat" && "%BEARSAMPP_NODEJS_PATH%\npm" config set globalconfig "%BEARSAMPP_NODEJS_CONFIG_PATH%" --global
  • Apply / Chat
Suggestion importance[1-10]: 8

__

Why: The suggestion correctly points out that using && instead of & improves the script's robustness by preventing the second command from running if the first one fails.

Medium
  • More

@jwaisner jwaisner merged commit 7498743 into main Aug 1, 2025
@jwaisner jwaisner deleted the 24.4.1 branch August 1, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug 🐛 For known bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants