Open
Conversation
✅ Deploy Preview for nostalgic-kare-ad710f ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
NSGolova
reviewed
Sep 17, 2023
| let owner = playerService.fetchPlayerOrGetFromCache(element); | ||
| if (owner?.playerId != playerId) { | ||
| canModify = false; | ||
| if (playerService.isMainPlayer(owner.playerId)) { |
Collaborator
There was a problem hiding this comment.
The cause of this issue is that I added keepOriginalId=true to the fetchPlayer request. So the player fetched by the old ID has it as a playerId property. Let's make it a param and set it here to false, so it will return a new ID.
Contributor
Author
|
i probably broke something somewhere with this >< |
NSGolova
force-pushed
the
master
branch
2 times, most recently
from
ae39552 to
0ff2e35
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if you created a playlist and then migrated your account you cannot delete it since the saved owner-id is still the one from the unmigrated account.