Skip to content
This repository was archived by the owner on Oct 10, 2018. It is now read-only.

Conversation

@JJK801
Copy link
Contributor

@JJK801 JJK801 commented Jun 22, 2014

This PR wiil make easier to install and launch BabitchClient by providing a multi mode docker image:

  • Prod mode: build with grunt & start an nginx server
  • Dev mode: Launch protractor's needed component, start a VNC server & a FTP Server for dev purposes
  • Test mode: Launch protractor's needed component then run tests (by this way, travis test docker image build and then launch tests in a container)

Todo:

  • Find a way to pass config variable to the container
  • Register repository in Docker Hub to automatically generate image

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all "production mode" had to be much more visible than dev or test mode :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're right 😄

@nchaulet
Copy link
Contributor

ProFTPd is really necessary ? a docker mount could be a more elegant solution ?

@JJK801
Copy link
Contributor Author

JJK801 commented Jun 26, 2014

@nchaulet i didn't find any other way to make wrapped files editable, i want to make a full packaged image usable in production, but also for dev purposes (make a PR quickly, without installing many useless component on the host), we also can use sshfs, but it's not a cross platform solution and a little bit harder to make it works.

@nchaulet
Copy link
Contributor

You can do something like this https://github.com/dockerfile/ghost a
packaged solution with overridable dir for dev purpose

2014-06-26 9:31 GMT+02:00 Jérémy JOURDIN notifications@github.com:

@nchaulet https://github.com/nchaulet i didn't find any other way to
make wrapped files editable, i want to make a full packaged image usable in
production, but also for dev purposes (make a PR quickly, without
installing many useless component on the host), we also can use sshfs, but
it's not a cross platform solution and a little bit harder to make it works.


Reply to this email directly or view it on GitHub
#88 (comment).

Nicolas Chaulet (Développeur Web)

Contact :

tél : 07 62 16 39 38
mail : n.chaulet@gmail.com
twitter : @n_chaulet <https://twitter.com/n_chaulet>

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants