Skip to content

option to specify filepath for SMART.* files#30

Open
riwu wants to merge 1 commit intoBenLand100:masterfrom
riwu:patch-2
Open

option to specify filepath for SMART.* files#30
riwu wants to merge 1 commit intoBenLand100:masterfrom
riwu:patch-2

Conversation

@riwu
Copy link
Contributor

@riwu riwu commented Dec 6, 2015

This will keep the directory of the scripts clean, and allows scripts started from a different directory to reuse the SMART.

I'm having trouble getting it to work though, the optional param isn't working (access violation if i leave out 1 argument). Any idea what i'm doing wrongly?

EDIT: removed the default arg, gave this error when the script is executed from a different directory than filepath:

Error: client.init:1103 sun.reflect.NativeMethodAccessorImpl.invoke0 sun.reflect
.NativeMethodAccessorImpl.invoke sun.reflect.DelegatingMethodAccessorImpl.invoke
 java.lang.reflect.Method.invoke Rs2Applet.a:116 Rs2Applet.init:509 smart.Client
.initFrame:618 smart.Client.<init>:141 smart.Main.main:954 | java.lang.RuntimeEx
ception |

looks like there's something else that relies on the SMART.* files?

@SRLJustin
Copy link

@riwu - That error is thrown no matter what client you use, even the official RuneScape client will throw the error (minus the smart.Client stuff)

@BenLand100
Copy link
Owner

This won't work because you haven't modified the methods in SmartRemote.cpp that search for these shared memory files, as is this code only creates the files in another location where they can't be found. It would make sense to pass this path to the SmartRemove plugin with a method other than spawnClient but this will get messy as it will change the location for every thread using the plugin. Would require a pretty big rethink of how the SHM files are handled to have them stored in a specific place - that's why I went with the CWD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants