option to specify filepath for SMART.* files#30
Open
riwu wants to merge 1 commit intoBenLand100:masterfrom
Open
option to specify filepath for SMART.* files#30riwu wants to merge 1 commit intoBenLand100:masterfrom
riwu wants to merge 1 commit intoBenLand100:masterfrom
Conversation
|
@riwu - That error is thrown no matter what client you use, even the official RuneScape client will throw the error (minus the smart.Client stuff) |
Owner
|
This won't work because you haven't modified the methods in SmartRemote.cpp that search for these shared memory files, as is this code only creates the files in another location where they can't be found. It would make sense to pass this path to the SmartRemove plugin with a method other than spawnClient but this will get messy as it will change the location for every thread using the plugin. Would require a pretty big rethink of how the SHM files are handled to have them stored in a specific place - that's why I went with the CWD. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will keep the directory of the scripts clean, and allows scripts started from a different directory to reuse the SMART.
I'm having trouble getting it to work though, the optional param isn't working (access violation if i leave out 1 argument). Any idea what i'm doing wrongly?
EDIT: removed the default arg, gave this error when the script is executed from a different directory than filepath:
looks like there's something else that relies on the SMART.* files?