fix: replace hashmap for btreemap for determinism#39
Merged
BenjaminRi merged 1 commit intoBenjaminRi:masterfrom Oct 12, 2025
Merged
fix: replace hashmap for btreemap for determinism#39BenjaminRi merged 1 commit intoBenjaminRi:masterfrom
BenjaminRi merged 1 commit intoBenjaminRi:masterfrom
Conversation
Owner
|
Hi, thank you for your contribution. This looks good to me, I'll merge it. Please note that this library does not make any guarantees with respect to reproducible builds. In particular, it calls |
Owner
|
Your change has been released in version 0.1.24. |
Contributor
Author
|
Thank you for the information ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After using winresource crate, my team and I encountered reproducible build failure. We manage to have it work with this patch inspired by mxre/winres#50
Iteration over Hashmap is not always in the same order, while with BTreeMap it is.