Skip to content

Conversation

@SuchAFuriousDeath
Copy link
Contributor

@SuchAFuriousDeath SuchAFuriousDeath commented Jan 19, 2026

I tried to find these in the library and it turns out they were missing.

@BenjaminRi
Copy link
Owner

Hi, thank you for your contribution. This looks good and CI passes as well. I will take a closer look in the coming days, it looks like this can be merged soon.

@SuchAFuriousDeath
Copy link
Contributor Author

It would be nice to get a new release to be able to make use of this in ruffle-rs/ruffle#22769, but it's not big deal if you don't feel like it.

@BenjaminRi BenjaminRi merged commit 56ddf95 into BenjaminRi:master Jan 23, 2026
4 checks passed
@BenjaminRi
Copy link
Owner

It would be nice to get a new release to be able to make use of this in ruffle-rs/ruffle#22769, but it's not big deal if you don't feel like it.

Don't worry, the only reason for delaying merging a PR that looks good is that I'm very busy and that I inspect the new code carefully before I accept it into the repository. It's very easy to break things or go in a wrong direction.

Your PR is now merged and published in winresource v0.1.30 🚀

@SuchAFuriousDeath SuchAFuriousDeath deleted the add-file-flags-constants branch January 23, 2026 16:53
@SuchAFuriousDeath
Copy link
Contributor Author

SuchAFuriousDeath commented Jan 23, 2026

I misphrased that a little bit, what I meant to say was that it's no big deal if you don't think these changes are enough for a new release.
Anyway, thanks for everything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants