Added semicolons to prevent minifying errors#14
Open
harm-less wants to merge 1 commit intoBenjaminsen:masterfrom
Open
Added semicolons to prevent minifying errors#14harm-less wants to merge 1 commit intoBenjaminsen:masterfrom
harm-less wants to merge 1 commit intoBenjaminsen:masterfrom
Conversation
On several places semicolons have been added because it caused errors due to certain minifying actions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On several places semicolons have been added because it caused errors
due to certain minifying actions if they weren't there.
Clarification:
Minified with fix (but kept the structure):
The second line from the bottom is important (
}(this), function(a, b) {). Without the fix it looks like this when minified:This doesn't play nice at all with the other libraries because it causes an error.
Actually only the last semicolon is important from this pull request, but I thought I'd add them to several other methods as well.