Fixed nested classes in AddTypeToLookup #234
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This causes problems elsewhere, I need to find where it uses those keys and update that too. And maybe something else? I should have checked more than just if I got the "successfully registered" text. EDIT, maybe it does work and it's my code that broke? I should look at this again when I have more sleep. I'm very confused. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some situations
AddTypeToLookupwould fail with nested classes, it would not get the full name properly.I added a
ClassInjector.GetTypeNamemethod very similar toClassInjector.GetIl2CppTypeFullNamethat accepts a enum for what parts of the name you want. Might not be the cleanest way to do it, especially considering it's only used in one place atm. But could be useful. Could also add that enum field to GetIl2CppTypeFullName, though not sure where you'd need that.These two changes together make it so that it doesn't try to double up on lookup keys in some cases with nested classes.