-
Notifications
You must be signed in to change notification settings - Fork 104
WIP: V2 Rewrite #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ds5678
wants to merge
212
commits into
BepInEx:master
Choose a base branch
from
ds5678:v2-rewrite
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
WIP: V2 Rewrite #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Clear * CopyTo * CopyFrom
Add a special case in the `GetNativeClassPointer` method of `Il2CppClassPointerStore` to explicitly handle the `void` type. This change ensures that the method returns the correct `NativeClassPtr` for `typeof(void)` instead of relying on the generic logic, which does not account for `void`.
* Fix HarmonySupport * Remake HarmonySupport to work without harmonyx * Revert InitOnly * Use FixedStruct instead of objects for value types * Delete logs for trampoline * Update Il2cppInteropDetour to use WithClone * Apply suggestions from code review Co-authored-by: Jeremy Pritts <49847914+ds5678@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Jeremy Pritts <49847914+ds5678@users.noreply.github.com> * Implement IsApplied * Update Il2cppInteropDetour to use WithClone * Delete Cloned SourceMethodClone --------- Co-authored-by: Jeremy Pritts <49847914+ds5678@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is unfinished; there are still things that need done.
Closes #108
Resolves #127
Resolves #128
Resolves #141
Resolves #142
Closes #143
Resolves #144
Resolves #145
Resolves #146
Resolves #147
Resolves #150
Resolves #152
Resolves #109
Resolves #174
Resolves #224
Resolves #218
Resolves #207
Resolves #176