Find GarbageCollector::RunFinalizer with xref scan as fallback #244
+100
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current `RunFinalizer` signatures can not reliably matches address of `RunFinalizer`, so fallback to xref scan as a last resort. `RunFinalizer` is used in `RegisterFinalizer`, and `RegisterFinalizer` is used in icall GC._ReRegisterForFinalize which is relatively simple compared to other users of `RegisterFinalizer`. So we can traversal into `GC._ReRegisterForFinalize` to find address of `RunFinalizer`. The xref scan handles both inlined and not inlined cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
RunFinalizersignatures can not reliably matches address ofRunFinalizer, so fallback to xref scan as a last resort.RunFinalizeris used inRegisterFinalizerandRegisterFinalizeris used in icallGC._ReRegisterForFinalize, which is relatively simple compared to other users ofRegisterFinalizer. So we can traversal intoGC._ReRegisterForFinalizeto find address ofRunFinalizer.The xref scan handles both inlined and not inlined cases.
Tested and verified the found RunFinalizer address to be actual RunFinalizer for both inlined and not inlined cases.