Skip to content

Conversation

@lola831
Copy link
Collaborator

@lola831 lola831 commented Nov 14, 2025

Description

This PR changes our pre-check for running tests/test_docs.py so that instead of just trying to connect to docs.python.org we now iterate through all configured Intersphinx URLs. Previously, CI would fail fairly often when one of these external inventories timed out during the Sphinx build, even though the pre-check had passed.

Issue Link

N/A

Checklist

  • I have tested the changes locally via pytest and/or other means
  • I have added or updated relevant documentation
  • I have autoformatted the code with black and isort
  • I have added test cases (if applicable)

Additional Notes

N/A

@lola831 lola831 requested a review from dfremont November 14, 2025 01:29
@lola831 lola831 changed the title Fix docs ci intersphinx Improve test_docs pre-check with Intersphinx URLs Nov 14, 2025
@codecov
Copy link

codecov bot commented Nov 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.99%. Comparing base (20292f3) to head (356686a).
⚠️ Report is 13 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #419      +/-   ##
==========================================
+ Coverage   89.89%   89.99%   +0.09%     
==========================================
  Files          54       54              
  Lines       13551    13580      +29     
==========================================
+ Hits        12182    12221      +39     
+ Misses       1369     1359      -10     

see 10 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@dfremont dfremont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just nitpicks.

@lola831
Copy link
Collaborator Author

lola831 commented Dec 18, 2025

@dfremont I restored the explanatory note and reverted the naming change.

@lola831 lola831 requested a review from dfremont December 18, 2025 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants