build sample multiplatform images for testing #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awilfox
approved these changes
Dec 12, 2025
Member
awilfox
left a comment
awilfox
left a comment
There was a problem hiding this comment.
Looks good to me other than a tiny style nit, but Dan has much more familiarity with the intricacies of this, so I'd like to wait for his review too before merging.
r+ from me after renaming of task.
anarchivist
force-pushed
the
multiplatform-testcase
branch
from
e7267e7 to
cce9b5d
Compare
anarchivist
added a commit
to BerkeleyLibrary/wowza
that referenced
this pull request
Dec 16, 2025
anarchivist
added a commit
to BerkeleyLibrary/wowza
that referenced
this pull request
Dec 16, 2025
anarchivist
added a commit
to BerkeleyLibrary/iipsrv
that referenced
this pull request
Dec 16, 2025
danschmidt5189
approved these changes
Dec 16, 2025
Member
danschmidt5189
left a comment
danschmidt5189
left a comment
There was a problem hiding this comment.
Looks good! Just one question about the matrix "platform" param.
| uses: docker/build-push-action@v6 | ||
| with: | ||
| push: true | ||
| platforms: ${{ matrix.platform }} |
Member
There was a problem hiding this comment.
Is this necessary because, without it, Docker infers an overly-specific platform from the current runner?
Member
Author
There was a problem hiding this comment.
i think so - iirc, this is how the Docker docs for GHA parallel multiplatform builds suggest how to do it.
anarchivist
added a commit
to BerkeleyLibrary/iipsrv
that referenced
this pull request
Dec 16, 2025
anarchivist
force-pushed
the
multiplatform-testcase
branch
from
d60f6b1 to
8045cf8
Compare
anarchivist
added a commit
to BerkeleyLibrary/avplayer
that referenced
this pull request
Dec 16, 2025
anarchivist
added a commit
to BerkeleyLibrary/wowza
that referenced
this pull request
Dec 17, 2025
anarchivist
added a commit
to BerkeleyLibrary/avplayer
that referenced
this pull request
Dec 17, 2025
* fix multiplatform builds ref BerkeleyLibrary/gha-testing#3 * copy out build artifacts
anarchivist
added a commit
to BerkeleyLibrary/iipsrv
that referenced
this pull request
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a slight variation avplayer's workflows. tldr: we were building multiplatform images, but they didn't get pushed when we were pushing the manifests. by definition,
docker pullonly pulls a single platform, and when wedocker pushed our tagged images, we were only pushing tags for a single architecture. we need to usedocker buildx imagetools createhere instead.