chatbot: Add Langfuse feedback support #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awilfox
commented
Dec 17, 2025
Member
Author
awilfox
left a comment
awilfox
left a comment
There was a problem hiding this comment.
Overall info about how this was developed.
willa/web/app.py
Outdated
Comment on lines
40
to
55
| async def get_step(self, step_id: str) -> Optional[StepDict]: | ||
| # Get step and related feedback | ||
| query = """ | ||
| SELECT s.*, | ||
| f.id feedback_id, | ||
| f.value feedback_value, | ||
| f."comment" feedback_comment | ||
| FROM "Step" s left join "Feedback" f on s.id = f."stepId" | ||
| WHERE s.id = $1 | ||
| """ | ||
| result = await self.execute_query(query, {"step_id": step_id}) | ||
| if not result: | ||
| return None | ||
| return self._convert_step_row_to_dict(result[0]) | ||
|
|
||
|
|
Member
Author
There was a problem hiding this comment.
This is a monkey patch for Chainlit/chainlit#2729.
Comment on lines
+79
to
+86
| get_langfuse_client().create_score( | ||
| name='feedback', | ||
| value=float(feedback.value), | ||
| session_id=step['threadId'] if not trace_id else None, | ||
| trace_id=trace_id, | ||
| data_type='BOOLEAN', | ||
| comment=feedback.comment | ||
| ) |
Comment on lines
109
to
113
| dl = ChainlitDataLayer(database_url=database_url) | ||
| dl.get_step = get_step.__get__(dl) | ||
| return dl |
Member
Author
There was a problem hiding this comment.
Horrible monkeypatch until Chainlit/chainlit#2729 is merged.
|
|
||
| if 'ai_message' in reply: | ||
| await cl.Message(content=reply['ai_message']).send() | ||
| cl.context.current_run.metadata['langfuse_trace_id'] = reply['langfuse_trace_id'] |
Member
Author
There was a problem hiding this comment.
Save the trace ID into the run metadata, which is where Chainlit stores Feedback objects (forId -> the run, not the message).
anarchivist
approved these changes
Dec 18, 2025
Member
anarchivist
left a comment
anarchivist
left a comment
There was a problem hiding this comment.
this looks great - thanks for submitting the upstream patch, too.
anarchivist
approved these changes
Dec 18, 2025
Co-authored-by: Dave Zuckerman <dzuckerm@berkeley.edu>
awilfox
force-pushed
the
awilfox/AP-531-feedback
branch
from
0f290a5 to
9394a6f
Compare
Member
Author
|
v2:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.