Skip to content

Conversation

@krrishdholakia
Copy link
Contributor

Title

Fix Milvus docs: Embed MilvusRESTClient implementation

Relevant issues

N/A

Pre-Submission checklist

Please complete all items before asking a LiteLLM maintainer to review your PR

  • I have Added testing in the tests/litellm/ directory, Adding at least 1 test is a hard requirement - see details
  • I have added a screenshot of my new test passing locally
  • My PR passes all unit tests on make test-unit
  • My PR's scope is as isolated as possible, it only solves 1 specific problem

Type

📖 Documentation

Changes

This PR addresses an issue in the Milvus vector store documentation where MilvusRESTClient was referenced without providing its implementation, leading to confusion for users.

The changes include:

  • Embedding the complete MilvusRESTClient Python code directly into the milvus_vector_stores.md documentation under a new "MilvusRESTClient" section.
  • Updating existing code examples to clarify that MilvusRESTClient should be used from the provided client code within the documentation.

This allows users to easily copy the necessary client code to their projects and follow the examples without encountering missing imports.


Slack Thread

Open in Cursor Open in Web

Co-authored-by: krrishdholakia <krrishdholakia@gmail.com>
@cursor
Copy link

cursor bot commented Dec 9, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@vercel
Copy link

vercel bot commented Dec 9, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
litellm Ready Ready Preview Comment Dec 9, 2025 7:16pm

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants