feat: Add renderName option #140
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micheljung
requested review from
a team,
Kirpal,
btrautmann,
jeroen-meijer,
jolexxa,
marcossevilla and
samandmoore
as code owners
micheljung
force-pushed
the
render-name-option
branch
from
9c36ee7 to
483fa98
Compare
micheljung
force-pushed
the
render-name-option
branch
from
483fa98 to
dd17670
Compare
Comment on lines
+83
to
+91
| if (config.renderName) ...<Widget>[ | ||
| Text( | ||
| name, | ||
| style: testTheme.nameTextStyle, | ||
| textHeightBehavior: const TextHeightBehavior( | ||
| applyHeightToFirstAscent: false, | ||
| ), | ||
| ), | ||
| ), | ||
| const SizedBox(height: 8), | ||
| const SizedBox(height: 8) |
Collaborator
There was a problem hiding this comment.
Suggested change
| if (config.renderName) ...<Widget>[ | |
| Text( | |
| name, | |
| style: testTheme.nameTextStyle, | |
| textHeightBehavior: const TextHeightBehavior( | |
| applyHeightToFirstAscent: false, | |
| ), | |
| ), | |
| ), | |
| const SizedBox(height: 8), | |
| const SizedBox(height: 8) | |
| if (config.renderName) ...[ | |
| Text( | |
| name, | |
| style: testTheme.nameTextStyle, | |
| textHeightBehavior: const TextHeightBehavior( | |
| applyHeightToFirstAscent: false, | |
| ), | |
| ), | |
| const SizedBox(height: 8), |
probably updating branch will complain about this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I want to use Alchemist for creating screenshots for app stores. Unfortunately, it always renders the name and an 8px spacer below it. While the name can be "removed" by giving it 0px size via theme, the spacer can not be removed.
With this change, the user can disable the rendering of the name and the spacer.
Type of Change