feat: Add an alias for same-package fonts #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikodembernat
requested review from
a team,
Kirpal,
btrautmann,
jeroen-meijer,
jolexxa,
marcossevilla and
samandmoore
as code owners
nikodembernat
changed the title
Author
|
Not a big fan of reading package name from |
Collaborator
|
@btrautmann Haven't touched our package or used it as intensely as you guys probably have. Can you verify the validity of the business logic here? Code itself LGTM. |
Author
|
From what I see the new goldens are failing since they don't exist, someone with necessary permissions has to regenerate them if I understand the workflow correctly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added an alias for same-package fonts to support running golden tests in packages (e.g. design systems).
Fixes #142
The specified
package:yamllower version constraint is equal topackage:yamlpinned in Flutter 3.16 (min. supported version) to avoid version conflicts.Type of Change