fix(picker-column): emit first change event #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebaferreras
commented
Jun 3, 2020
Comment on lines
-407
to
-411
| if (this.lastIndex === undefined) { | ||
| // have not set a last index yet | ||
| this.lastIndex = this.col.selectedIndex; | ||
|
|
||
| } else if (this.lastIndex !== this.col.selectedIndex) { |
Collaborator
Author
There was a problem hiding this comment.
lastIndex is only used in these three lines of code, and I couldn't find any reason why the first event shouldn't be emitted to the parent component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
The first "change" event from the
PickerColumnCmpis not being emitted. The selected value is being updated behind the scenes, but the change is not communicated to the parent component/page.This is not a bug in the way Ionic uses the component because the picker component doesn't update the input field value as the user changes the picker column – the input field is updated once the user clicks the "Done" button (https://i.gyazo.com/bdea4dc2f68c2b510b2c6fd231fe5fd3.mp4).
But it is a bug if you try to use the columns directly in another page/component and not as part of the
PickerComponentChanges proposed in this pull request:
Emit the first change event