Skip to content

Conversation

@piedoom
Copy link
Contributor

@piedoom piedoom commented Nov 26, 2025

Some nodes were missing derives or weren't implementing reflect/serde. I used the derives in delay_compensation as a guide. The exception is the sampler node, as ArcGc doesn't have the necessary derives, so I left that off. (Maybe it can be safely skipped? I'm not sure how to handle the smart pointers here)

@BillyDM
Copy link
Owner

BillyDM commented Nov 28, 2025

Ok, thanks!

I don't think serde/reflection would make sense for the ArcGc pointers since it requires a garbage collector instance to be constructed. And furthermore it wouldn't make sense for the sampler node because you wouldn't want to serde/reflect the entire audio file resource.

I suppose we could skip the ArcGc field. The user just has to make sure they fill in the sample resource manually later.

@piedoom
Copy link
Contributor Author

piedoom commented Nov 29, 2025

Thanks! Updated sampler to fit your comments.

@BillyDM BillyDM merged commit 30446e0 into BillyDM:main Nov 29, 2025
3 checks passed
@piedoom piedoom deleted the derive_normalization branch December 1, 2025 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants