Skip to content

Use lazy task configuration #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vgalloy wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use lazy task configuration #112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 11 additions & 15 deletions src/main/java/com/bisnode/opa/OpaPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,23 +21,19 @@ public class OpaPlugin implements Plugin<Project> {

@Override
public void apply(Project project) {
project.getExtensions().create(OpaExtension.class, "opa", DefaultOpaExtension.class);
OpaExtension opaExtension = project.getExtensions().create(OpaExtension.class, "opa", DefaultOpaExtension.class);

TaskContainer tasks = project.getTasks();
List<Task> addedTasks = new ArrayList<>();
addedTasks.add(tasks.create("startOpa", StartOpaTask.class));
addedTasks.add(tasks.create("stopOpa", StopOpaTask.class));
addedTasks.add(tasks.create("testRego", TestRegoTask.class));
addedTasks.add(tasks.create("testRegoCoverage", TestRegoCoverageTask.class));
List<TaskProvider<?>> addedTasks = new ArrayList<>();
addedTasks.add(tasks.register("startOpa", StartOpaTask.class));
addedTasks.add(tasks.register("stopOpa", StopOpaTask.class));
addedTasks.add(tasks.register("testRego", TestRegoTask.class));
addedTasks.add(tasks.register("testRegoCoverage", TestRegoCoverageTask.class));

project.afterEvaluate(currentProject -> applyToRootProject(currentProject, addedTasks));
project.afterEvaluate(currentProject -> applyToRootProject(currentProject, opaExtension, addedTasks));
}

private void applyToRootProject(Project project, List<Task> dependentTasks) {
OpaExtension opaExtension = project.getExtensions().findByType(OpaExtension.class);
if (opaExtension == null) {
return;
}
private void applyToRootProject(Project project, OpaExtension opaExtension, List<TaskProvider<?>> dependentTasks) {
if (!ExecutableMode.DOWNLOAD.equals(opaExtension.getMode())) {
return;
}
Expand All @@ -57,7 +53,7 @@ private void applyToRootProject(Project project, List<Task> dependentTasks) {
}
}

private synchronized void applyDownloadTask(Project project, String version, List<Task> dependentTasks) {
private synchronized void applyDownloadTask(Project project, String version, List<TaskProvider<?>> dependentTasks) {
final String taskName = String.format("%s_%s", DownloadOpaTask.TASK_BASE_NAME, version);
final File opaExecutable = OpaPlatform.getPlatform().getExecutablePath(project.getBuildDir().toPath(), version).toFile();
Set<Task> downloadTasks = project.getTasksByName(taskName, false);
Expand All @@ -71,8 +67,8 @@ private synchronized void applyDownloadTask(Project project, String version, Lis
downloadTasks.add(downloadTask.get());
}
downloadTasks.forEach(downloadTask -> dependentTasks.forEach(task -> {
task.dependsOn(downloadTask);
final OpaExtension opaExtension = task.getExtensions().findByType(OpaExtension.class);
task.get().dependsOn(downloadTask);
final OpaExtension opaExtension = task.get().getExtensions().findByType(OpaExtension.class);
if (opaExtension != null) {
opaExtension.setLocation(opaExecutable.getParent());
}
Expand Down