Conversation
|
@Greg-Griffith I noticed that you regenerate the PDF from scratch and I like the new formatting more than the old one by the way. I'm just wondering how we could manage to review this kind of PR which are changing binaries in an efficient way. So far the only way that comes to my mind is to extract text from AoF pdf versions and comparing them somehow. Do you have any better idea? Having said that I skimmed the new AoF version and this are a series of feedback that goes beyond the scope of this PR but I think it's worth sharing regardless:
|
|
@sickpig I actually did not notice that resulted in different formatting. I got a hold of the original word doc and re-exported it to pdf without actually looking at the pdf except to check that the spacing for that one line was fixed. Looking at it now, i think the different formatting between 1,4 and 2,3 are due to 2 and 3 not having section titles where as 1 and 4 do. Also just noticed that the last paragraph (the actual agreement) is currently in bold on the website but is not in my re-export. I will adjust the title of this PR and go back through my re-export to make formatting consistent |
672c19b to
1a1a529
Compare
1a1a529 to
40d3aff
Compare
|
@gandrewstone @AndrewClifford could you please have a look at this PR. We need to make sure that the formatting improved while at the same time the actual content didn't get modified inadvertently. I wonder if we could move the sys to have a, let say, markdown version of the article that we use as a source and that we convert to a pdf at run-time when needed. This would make this kind of review a lot easier. |
section 2.5 formatting adjusted so 2.5 now starts on its own line