Updated make-agent validation, migrate validation & tests to bitte-ai-spec package #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Markeljan
requested review from
GAllen98,
SurgeCode,
bh2smith,
microchipgnu,
rubenmarcus and
sainthiago
Markeljan
changed the title
Markeljan
force-pushed
the
advanced-schema-declaration-and-validation
branch
from
1a696eb to
b24e551
Compare
rubenmarcus
approved these changes
Feb 17, 2025
bh2smith
approved these changes
Feb 17, 2025
Contributor
There was a problem hiding this comment.
Looks good. Are we creating a monorepo for all these scattered little packages, or just a bunch of scattered repos? I created the agent-sdk in bitteprotocol/core which is all setup for this. Its just waiting for a buddy to join.
Comment on lines
-39
to
-41
| "@apidevtools/swagger-parser": "^10.1.0", | ||
| "ajv": "^8.17.1", | ||
| "ajv-draft-04": "^1.0.0", |
| `Attempt ${attempt}/${maxAttempts}: Error detecting port:`, | ||
| winError, | ||
| `Attempt ${attempt}/${maxAttempts}: Error detecting port.`, | ||
| // winError, mute winError to prevent large, unneccesary console output |
Contributor
There was a problem hiding this comment.
I would just delete this and put the comment in a comment here.
Suggested change
| // winError, mute winError to prevent large, unneccesary console output |
sainthiago
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
make-agentvalidationOpenAPI spec + Zod schema validation using new package
bitte-ai-spec(temporary but live on NPM).Export new
BitteOpenAPISpectype from make-agentNew command
make-agent validate [source](can pass a path to json file or remote url to test spec validation)Can test here on agent template branch:
BitteProtocol/agent-next-boilerplate#18