This repository was archived by the owner on Dec 18, 2024. It is now read-only.
Open
Conversation
Merged
Member
|
Works surprisingly fine for me. Sadly one exception I found are scratchpads where animations break in some cases (some incomming animations I think). The module probably checks for whether the scrachpad is already on the tag, which is true for this PR but false for the current code |
Contributor
Author
|
hmmmm how about creating 2 sets of helpers, one just for the scratchpads and the other for everything else? or perhaps have another argument for the helper that is only passed on the scratchpads module? |
Contributor
Author
|
soon™ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changed the
_client.turn_off()and_client.turn_on()helpers to use thec.hiddenproperty instead of the tagging/untagging dance in accordance to a comment in #140so far this seems to work or the swallowing module and i haven't found any particular new corner case
testing for scratchpads and the tabbed module need to be done.