Update markup after paste (BL-15334)#7677
Conversation
JohnThomson
force-pushed
the
updateMarkupPaste
branch
from
6998884 to
2aa837c
Compare
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
JohnThomson
force-pushed
the
updateMarkupPaste
branch
from
2aa837c to
0246dd3
Compare
| // AI thinks we might need this to allow the DOM to settle even before we do the | ||
| // little bit that handlePageEditing does before setting up its own delay. |
There was a problem hiding this comment.
📝 Info: Comment references AI suggestion — consider updating before merge
The comments at lines 1077 and 227 reference AI suggestions ("AI thinks we might need this" and "AI suggested adding these"). While not a code issue, these comments could be confusing for future maintainers. Consider rephrasing to describe the technical rationale (DOM settling / catching async paste completion) rather than attributing the decision to an AI tool.
Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
The AI comment was exceptionally unhelpful and seemed to be based on an expectation that things being done after the 500ms delay were instead being done immediately. Maybe I should have quoted it word-for-word, but I don't still have it. Since I have not managed to understand myself why we need this additional timeout (if we do), I can't write a more intelligible explanation than that I suggested it.
JohnThomson
left a comment
JohnThomson
left a comment
There was a problem hiding this comment.
@JohnThomson made 2 comments.
Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @hatton).
| // AI thinks we might need this to allow the DOM to settle even before we do the | ||
| // little bit that handlePageEditing does before setting up its own delay. |
There was a problem hiding this comment.
The AI comment was exceptionally unhelpful and seemed to be based on an expectation that things being done after the 500ms delay were instead being done immediately. Maybe I should have quoted it word-for-word, but I don't still have it. Since I have not managed to understand myself why we need this additional timeout (if we do), I can't write a more intelligible explanation than that I suggested it.
andrew-polk
left a comment
andrew-polk
left a comment
There was a problem hiding this comment.
@andrew-polk reviewed 3 files and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @JohnThomson).
3 participants
This change is