Skip to content

Fixes bugs#56

Open
aaronw4 wants to merge 5 commits intomasterfrom
feature/fix_update_profile
Open

Fixes bugs#56
aaronw4 wants to merge 5 commits intomasterfrom
feature/fix_update_profile

Conversation

@aaronw4
Copy link
Collaborator

@aaronw4 aaronw4 commented Jun 25, 2020

Description

  1. While on the profile page, a user has the option to update their display name. The 'update profile' button was not updating the profile.
  2. Categories were not being assigned to tasks under certain circumstances.
  3. Completed tasks were not being marked as completed.

Fixes # (issue)

  1. The end point href in the actions file was incorrect. This PR puts the correct endpoint in the function updateUser.
  2. Some functions that create a task were missing the category ID. This has been fixed.
  3. The completed task function was refreshing the page before the axios call had been completed. This was fixed by turning it into an async function.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Change Status

  • Complete, tested, ready to review and merge

How Has This Been Tested?

Ran locally on my computer.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My code has been reviewed by at least one peer
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • There are no merge conflicts

@aaronw4 aaronw4 changed the title Fixes bug of not being able to update profile Fixes bugs Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant