Further code cleanup #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* convert some CR/LF line endings to LF * be explicit about assignment operations within conditionals * remove some unused variables * add const to string literal argument types Helps fix BoevaLab#11.
Contributor
|
Some unused variables were still present in the code for debug purposes. |
Author
|
Do you mean you want to keep the ones removed in this PR, or "set but not used" ones I mentioned on GCC warns about on Linux? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes all build errors on Mac except for warnings about deprecation of
gamma.gammais not supposed to be inmath.hand is now marked deprecated but still clashes with the version in FREEC. This means Mac builds use the wrong function – could potentially fix by renaming the FREEC one?Linux builds still have quite a few warnings about set but not used variables and uninitiallized variables. Not 100% clear to me what the intention is for them so have left that alone for now.
I have not tested these changes.
Helps fix #11.