Skip to content

Conversation

@adriencaccia
Copy link

@adriencaccia adriencaccia commented Nov 20, 2025

Hey, I am a co-founder at @CodSpeedHQ, really glad to have you use it!

I checked out the repository after @hellovai contacted us, and found there were an improvement that could be made to the setup!

Changes

  • bumped CodSpeedHQ/action to v4
  • used the working-directory input instead of using cd inside the run input

Thanks to those changes, you will normally benefit from automated profiling on your benchmarks!

Additional Notes

There is an issue with the benchmarks generated with

include!(concat!(env!("OUT_DIR"), "/generated_benchmarks.rs"));
, their dashboard is not accessible because their URI is malformed (it contains the whole path, eg: /actions-runner/_work/baml/baml/baml_language/target/release/build/baml_tests-74008be547e634ff/out/generated_benchmarks.rs::bench_incremental_add_attribute). We will take a look to at least try to make their dashboard work.


Note

Bumps CodSpeed action to v4 and switches to the working-directory input for running benchmarks.

  • CI (.github/workflows/ci.yaml):
    • Benchmarks job (benchmarks-instrumented):
      • Update CodSpeedHQ/action from v3 to v4.
      • Use working-directory: baml_language input instead of cd in run.
      • Adjust run to cargo codspeed run with mode: walltime and token unchanged.

Written by Cursor Bugbot for commit 1647a0e. This will update automatically on new commits. Configure here.

@vercel
Copy link

vercel bot commented Nov 20, 2025

@adriencaccia is attempting to deploy a commit to the Boundary Team on Vercel.

A member of the Team first needs to authorize it.

@hellovai hellovai enabled auto-merge November 20, 2025 13:16
@aaronvg
Copy link
Contributor

aaronvg commented Nov 20, 2025

thanks!

@hellovai hellovai added this pull request to the merge queue Nov 20, 2025
github-merge-queue bot pushed a commit that referenced this pull request Nov 20, 2025
Hey, I am a co-founder at @CodSpeedHQ, really glad to have you use it!

I checked out the repository after @hellovai contacted us, and found
there were an improvement that could be made to the setup!

## Changes
- bumped [`CodSpeedHQ/action`](https://github.com/CodSpeedHQ/action/) to
v4
- used the `working-directory` input instead of using `cd` inside the
`run` input

Thanks to those changes, you will normally benefit from [automated
profiling](https://codspeed.io/docs/instruments/walltime#automated-profiling)
on your benchmarks!

## Additional Notes

There is an issue with the benchmarks generated with
https://github.com/BoundaryML/baml/blob/514afc9dcbccd692dd7c59f53f69b45169984524/baml_language/crates/baml_tests/benches/compiler_benchmark.rs#L319,
their dashboard is not accessible because their URI is malformed (it
contains the whole path, eg:
`/actions-runner/_work/baml/baml/baml_language/target/release/build/baml_tests-74008be547e634ff/out/generated_benchmarks.rs::bench_incremental_add_attribute`).
We will take a look to at least try to make their dashboard work.
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 20, 2025
@aaronvg aaronvg enabled auto-merge November 25, 2025 01:20
run: cd baml_language && cargo codspeed run
run: cargo codspeed run
token: ${{ secrets.CODSPEED_TOKEN }}
working-directory: baml_language
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Invalid working-directory usage with action input

The working-directory keyword is being passed as an input to the CodSpeedHQ/action@v4 composite action. However, GitHub Actions only supports working-directory on run: steps and in defaults.run, not as a standard input parameter for actions. Unless CodSpeedHQ/action@v4 explicitly defines working-directory as an input in its action.yaml, this parameter will be ignored and the action will execute from the root repository directory instead of baml_language, causing the benchmark run to fail.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants