-
Notifications
You must be signed in to change notification settings - Fork 341
chore(ci): fix CodSpeed working directory #2732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: canary
Are you sure you want to change the base?
Conversation
|
@adriencaccia is attempting to deploy a commit to the Boundary Team on Vercel. A member of the Team first needs to authorize it. |
|
thanks! |
Hey, I am a co-founder at @CodSpeedHQ, really glad to have you use it! I checked out the repository after @hellovai contacted us, and found there were an improvement that could be made to the setup! ## Changes - bumped [`CodSpeedHQ/action`](https://github.com/CodSpeedHQ/action/) to v4 - used the `working-directory` input instead of using `cd` inside the `run` input Thanks to those changes, you will normally benefit from [automated profiling](https://codspeed.io/docs/instruments/walltime#automated-profiling) on your benchmarks! ## Additional Notes There is an issue with the benchmarks generated with https://github.com/BoundaryML/baml/blob/514afc9dcbccd692dd7c59f53f69b45169984524/baml_language/crates/baml_tests/benches/compiler_benchmark.rs#L319, their dashboard is not accessible because their URI is malformed (it contains the whole path, eg: `/actions-runner/_work/baml/baml/baml_language/target/release/build/baml_tests-74008be547e634ff/out/generated_benchmarks.rs::bench_incremental_add_attribute`). We will take a look to at least try to make their dashboard work.
| run: cd baml_language && cargo codspeed run | ||
| run: cargo codspeed run | ||
| token: ${{ secrets.CODSPEED_TOKEN }} | ||
| working-directory: baml_language |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Invalid working-directory usage with action input
The working-directory keyword is being passed as an input to the CodSpeedHQ/action@v4 composite action. However, GitHub Actions only supports working-directory on run: steps and in defaults.run, not as a standard input parameter for actions. Unless CodSpeedHQ/action@v4 explicitly defines working-directory as an input in its action.yaml, this parameter will be ignored and the action will execute from the root repository directory instead of baml_language, causing the benchmark run to fail.
Hey, I am a co-founder at @CodSpeedHQ, really glad to have you use it!
I checked out the repository after @hellovai contacted us, and found there were an improvement that could be made to the setup!
Changes
CodSpeedHQ/actionto v4working-directoryinput instead of usingcdinside theruninputThanks to those changes, you will normally benefit from automated profiling on your benchmarks!
Additional Notes
There is an issue with the benchmarks generated with
baml/baml_language/crates/baml_tests/benches/compiler_benchmark.rs
Line 319 in 514afc9
/actions-runner/_work/baml/baml/baml_language/target/release/build/baml_tests-74008be547e634ff/out/generated_benchmarks.rs::bench_incremental_add_attribute). We will take a look to at least try to make their dashboard work.Note
Bumps CodSpeed action to v4 and switches to the
working-directoryinput for running benchmarks.benchmarks-instrumented):CodSpeedHQ/actionfromv3tov4.working-directory: baml_languageinput instead ofcdinrun.runtocargo codspeed runwithmode: walltimeand token unchanged.Written by Cursor Bugbot for commit 1647a0e. This will update automatically on new commits. Configure here.