Skip to content

Conversation

@antoniosarosi
Copy link
Contributor

No description provided.

antoniosarosi and others added 4 commits December 8, 2025 17:16
Add #[allow(...)] attributes with explanatory comments for:
- cast_sign_loss: instruction pointers are validated non-negative
- cast_possible_wrap: lengths won't exceed i64::MAX
- cast_possible_truncation: bounds are checked before use
- float_cmp: intentional exact comparison for equality operators
- print_stderr: intentional debug output
- format_push_string: replaced with write!/writeln!
- from_iter_instead_of_collect: replaced with .collect()
- match_wildcard_for_single_variants: use explicit variant
- needless_pass_by_value: take reference instead

Also fix test utilities and benchmark:
- Add #[allow(dead_code)] to tests/common.rs
- Update benches/fib.rs to use baml_codegen instead of baml_compiler
- Replace Default::default() with HashMap::default()

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@vercel
Copy link

vercel bot commented Dec 8, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
promptfiddle Error Error Dec 10, 2025 1:41pm

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 8, 2025

CodSpeed Performance Report

Merging #2786 will not alter performance

Comparing antonio/codegen (91c85ee) with canary (23f367f)

Summary

✅ 15 untouched
⏩ 14 skipped1

Footnotes

  1. 14 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Move test utilities from baml_vm::test and baml_codegen::tests into
baml_tests crate, removing anyhow from [dependencies] in both crates.

- Create baml_tests/src/vm.rs (test-friendly VM representations)
- Create baml_tests/src/codegen.rs (bytecode compilation test utils)
- Update imports in baml_codegen/tests/*.rs
- Fix rustdoc broken intra-doc links in baml_vm

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@antoniosarosi antoniosarosi added this pull request to the merge queue Dec 10, 2025
Merged via the queue into canary with commit 37484c6 Dec 10, 2025
37 of 38 checks passed
@antoniosarosi antoniosarosi deleted the antonio/codegen branch December 10, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants