-
Notifications
You must be signed in to change notification settings - Fork 341
Port baml_vm to baml_language
#2786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add #[allow(...)] attributes with explanatory comments for: - cast_sign_loss: instruction pointers are validated non-negative - cast_possible_wrap: lengths won't exceed i64::MAX - cast_possible_truncation: bounds are checked before use - float_cmp: intentional exact comparison for equality operators - print_stderr: intentional debug output - format_push_string: replaced with write!/writeln! - from_iter_instead_of_collect: replaced with .collect() - match_wildcard_for_single_variants: use explicit variant - needless_pass_by_value: take reference instead Also fix test utilities and benchmark: - Add #[allow(dead_code)] to tests/common.rs - Update benches/fib.rs to use baml_codegen instead of baml_compiler - Replace Default::default() with HashMap::default() 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
CodSpeed Performance ReportMerging #2786 will not alter performanceComparing Summary
Footnotes
|
Move test utilities from baml_vm::test and baml_codegen::tests into baml_tests crate, removing anyhow from [dependencies] in both crates. - Create baml_tests/src/vm.rs (test-friendly VM representations) - Create baml_tests/src/codegen.rs (bytecode compilation test utils) - Update imports in baml_codegen/tests/*.rs - Fix rustdoc broken intra-doc links in baml_vm 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.