6 feature integrate feedback #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MarcelRosier
commented
Sep 3, 2025
MarcelRosier
commented
- Add citation reminder
- Fix param order in example
- Add logging info
- Add logging of weights location
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
Author
|
Reminder looks like this: |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR integrates user feedback by adding citation reminders, fixing parameter order, and improving logging functionality. The changes enhance user experience by providing proper attribution guidance and better debugging capabilities.
- Added a citation reminder decorator to prompt users to cite relevant papers when using the segmentation tool
- Fixed parameter order in the README example to match the actual function signature
- Enhanced logging with informational messages and documentation on how to enable logging
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| stroke_segmentor/utils/citation_reminder.py | New module implementing a decorator to display citation information |
| stroke_segmentor/inferer.py | Applied citation reminder decorator to the main inference method |
| stroke_segmentor/zenodo.py | Added logging statement for extraction completion |
| README.md | Fixed parameter order in example, added logging documentation, and expanded citation section |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
neuronflow
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.