Draft
Conversation
Lut99
reviewed
Oct 8, 2024
| @@ -3,13 +3,14 @@ name = "brane-ctl" | |||
| version = { workspace = true } | |||
| edition = "2021" | |||
| authors = [ "Tim Müller" ] | |||
There was a problem hiding this comment.
By the way! Unrelated to this PR, but don't be afraid to add yourself as author ;)
| let certs: PathBuf = resolve_config_path(certs, &config_path); | ||
|
|
||
| // Ensure the directory structure is there | ||
| // TODO: Does not really seem like the responsibility of generating a node as if these |
There was a problem hiding this comment.
OK good catch xD it should just be an assert instead, then.
| /// | ||
| /// # Errors | ||
| /// This function errors if we failed to interact with the user. | ||
| // TODO: This should be display preferable I would think |
| /// A new Address instance. | ||
| #[inline] | ||
| // TODO: Maybe it is better to just implement From<(Ipv4Addr>, u16)> | ||
| // Having n+1 constructors seems a bit excessive |
There was a problem hiding this comment.
Also fine. I think I did it because I would be too lazy to create an Ipv4Addr the whole time instead of just adding the numbers directly. You can also implement From<((u8, u8, u8, u8), u16> in addition for convenience.
| pub const CERTIFICATE_PATH: &str = "certs"; | ||
| pub const PACKAGE_PATH: &str = "packages"; | ||
|
|
||
| pub const NODE_HEADER: &str = indoc::indoc!(" |
Not yet finished, but we are getting quite far along. Some code paths contain todo!() macros and some ports are still defined to garbage
DanielVoogsgerd
force-pushed
the
wizard
branch
from
09598ba to
e6930c1
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
devskim found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this is still very much a draft. Feel free to look around if you are interested.
Suggestions are welcome as always, but a lot of stuff still needs to be written, rewritten, and restructured.
I do want some sort of place where progress can be seen and tracked so this will be just that.
To Do:
Did I mention it is a draft? 😆