Open
Conversation
Also moved these integration tests to the correct location for integration tests
DanielVoogsgerd
added
E-Easy
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Lut99
approved these changes
May 12, 2025
Lut99
left a comment
Lut99
left a comment
There was a problem hiding this comment.
Looks good! I don't have much experience with either snapshot testing or this framework, but I like the idea!
Note that the brane_shr::utilities repo is, actually, mostly implementing test stuff. Just a consideration for if you want to reorganize based on that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces Cargo insta for snapshot testing.
I started by moving the branescript and bakery tests from the unit test section to a integration test section and then added snapshot testing on top of it.
Note that this is purely regression testing, for all I know all parsing is done incorrectly now, it it just self-consistent with previous results.
Not of particular interest for this PR, but we also need negative testing for branescript to make sure a nom update for example does not mess with error reporting