Adding detailled Docker profile times to local_run() in brane-cli#275
Open
Adding detailled Docker profile times to local_run() in brane-cli#275
local_run() in brane-cli#275Conversation
Implemented some across-the-board fixes for the profiling lib. Not perfect, but hey, who is.
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A student wants to benchmark the costs of managing container lifetimes (i.e., spawning them, destroying them, etc). As such, improved (and actually implemented) profile times for local container execution in
brane-cli.NOTE: Please don't remove the branch after merging, I'll do that myself to ensure the student can rely on accurate work :)