Copy all avaiable input streams to the output#51
Open
elijahmathews wants to merge 1 commit intoBrettSheleski:masterfrom
Open
Copy all avaiable input streams to the output#51elijahmathews wants to merge 1 commit intoBrettSheleski:masterfrom
elijahmathews wants to merge 1 commit intoBrettSheleski:masterfrom
Conversation
Owner
|
Awesome, will review when I'm at a computer. First glance on my phone looks great. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
comchap(and I believecomcutas well) does not copy the all input streams to the chapterized/trimmed output file. I've mostly noticed this with inputs that have multiple audio streams included within, where only the first of these streams ends up landing in the output.This pull request should address this by adding
-map 0to the FFmpeg command to ensure that all streams (e.g. video, audio, subtitles) are copied into the output.