fix for Node v8 (Object.setPrototypeOf called on null or undefined)#14
Open
DoNck wants to merge 1 commit intoBrianMMcClain:masterfrom
Open
fix for Node v8 (Object.setPrototypeOf called on null or undefined)#14DoNck wants to merge 1 commit intoBrianMMcClain:masterfrom
DoNck wants to merge 1 commit intoBrianMMcClain:masterfrom
Conversation
I am a user of Node-RED I was using the output node "node-red-artnet-node" relying on this "artnet-node" package and it came to prevent my Node-RED from starting after upgrading to Node-RED v0.17.5 and Node.js v8.9.1. To fix it, I refactored the server stuff following the advices found at: https://stackoverflow.com/questions/39099527/typeerror-object-setprototypeof-called-on-null-or-undefined I'm not a expert of javascript nor of Node.js and couldn't try my new version with Artnet hardware. I think it should work again but PLEASE READ CAREFULLY MY PR BEFORE MERGING ! At least, my server doesnt crash anymore at startup nor when trying to send Artnet stuffs from Node-RED :D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am a user of Node-RED
I was using the output node "node-red-artnet-node" relying on this
"artnet-node" package and it came to prevent my Node-RED from starting after upgrading to Node-RED v0.17.5 and Node.js v8.9.1 because of
TypeError: Object.setPrototypeOf called on null or undefinedTo fix it, I refactored the server stuff following the advices found at:
https://stackoverflow.com/questions/39099527/typeerror-object-setprototypeof-called-on-null-or-undefined
I'm not a expert of javascript nor of Node.js and couldn't try my new
version with Artnet hardware.
I think it should work again but PLEASE READ CAREFULLY MY PR BEFORE MERGING !
At least, my server doesnt crash anymore at startup nor when trying to send Artnet stuffs from Node-RED :D